Skip to content

Media: Reset gallery modal state when abandoning a new gallery#12297

Draft
ArkaPrabhaChowdhury wants to merge 2 commits into
WordPress:trunkfrom
ArkaPrabhaChowdhury:trac-57489-gallery-modal-reset
Draft

Media: Reset gallery modal state when abandoning a new gallery#12297
ArkaPrabhaChowdhury wants to merge 2 commits into
WordPress:trunkfrom
ArkaPrabhaChowdhury:trac-57489-gallery-modal-reset

Conversation

@ArkaPrabhaChowdhury

Copy link
Copy Markdown

Media: Reset gallery modal state when abandoning a new gallery

What?

  • clear the transient gallery-edit, gallery, and gallery-library selections when the media modal closes during a new gallery flow
  • add a QUnit regression that covers closing an abandoned gallery before insertion

Why?

The gallery add state excludes attachments already staged in gallery-edit. When the modal is closed before the gallery is inserted, that staged selection leaks into the next create-gallery flow and can make the media library appear empty.

Testing

  • php vendor/bin/phpcbf --standard=phpcs.xml.dist src/js/media/views/frame/post.js tests/qunit/wp-admin/js/media/post-frame.js
  • php vendor/bin/phpcs --standard=phpcs.xml.dist src/js/media/views/frame/post.js tests/qunit/wp-admin/js/media/post-frame.js
  • npm run grunt -- jshint:corejs
  • npx playwright test --config tests/qunit/playwright.config.js
  • npm run typecheck:js

Trac ticket: https://core.trac.wordpress.org/ticket/57489

@github-actions

Copy link
Copy Markdown

Hi there! 👋

Thank you for your contribution to WordPress! 💖

It looks like this is your first pull request to wordpress-develop. Here are a few things to be aware of that may help you out!

No one monitors this repository for new pull requests. Pull requests must be attached to a Trac ticket to be considered for inclusion in WordPress Core. To attach a pull request to a Trac ticket, please include the ticket's full URL in your pull request description.

Pull requests are never merged on GitHub. The WordPress codebase continues to be managed through the SVN repository that this GitHub repository mirrors. Please feel free to open pull requests to work on any contribution you are making.

More information about how GitHub pull requests can be used to contribute to WordPress can be found in the Core Handbook.

Please include automated tests. Including tests in your pull request is one way to help your patch be considered faster. To learn about WordPress' test suites, visit the Automated Testing page in the handbook.

If you have not had a chance, please review the Contribute with Code page in the WordPress Core Handbook.

The Developer Hub also documents the various coding standards that are followed:

Thank you,
The WordPress Project

@github-actions

Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant