[pull] master from monkeytypegame:master#896
Merged
Merged
Conversation
…Leonabcd123) (#8038) Fixes #8037 Not sure whether `stop on error = word` should have any effect when `nospace` is enabled, so this pr currently only fixes the case where a mistake isn't blocked at the end of a word in `nospace`.
Bumps [lru-cache](https://github.com/isaacs/node-lru-cache) from 7.10.1 to 11.5.1. <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/isaacs/node-lru-cache/blob/main/CHANGELOG.md">lru-cache's changelog</a>.</em></p> <blockquote> <h1>cringe lorg</h1> <h2>11.5</h2> <ul> <li>Add <code>backgroundFetchSize</code> option, defaulting to 1, to set an effective size for provisional background fetch objects while in flight, if they do not shadow an existing stale entry.</li> </ul> <h2>11.4</h2> <ul> <li>Add <code>cache</code> property to status objects, in order to differentiate which cache is emitting the metric or trace.</li> <li>Several small bugs regarding fetch behavior edge cases. <ul> <li><code>onInsert</code> does not fire for background fetch internal promises.</li> <li><code>dispose()</code> and <code>disposeAfter()</code> now fire for the stale value left behind when an in-process background fetch is pre-empted by eviction.</li> <li><code>fetchMethod</code> that returns a non-Promise value is handled correctly.</li> <li>No <code>Error</code> is created, or <code>abort()</code> signaled, when a background fetch promise is resolved. (Presumably the implementation is done by that point.)</li> </ul> </li> </ul> <h2>11.3</h2> <ul> <li>Add observability features, expand the coverage of <code>LRUCache.Status</code> objects.</li> </ul> <h2>11.2</h2> <ul> <li>Add the <code>perf</code> option to specify <code>performance</code>, <code>Date</code>, or any other object with a <code>now()</code> method that returns a number.</li> </ul> <h2>11.1</h2> <ul> <li>Add the <code>onInsert</code> method</li> </ul> <h2>11.0</h2> <ul> <li>Drop support for node less than v20</li> </ul> <h2>10.4</h2> <ul> <li>Accidental minor update, should've been patch.</li> </ul> <h2>10.3</h2> <ul> <li>add <code>forceFetch()</code> method</li> <li>set <code>disposeReason</code> to <code>'expire'</code> when it's the result of a TTL</li> </ul> <!-- raw HTML omitted --> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/isaacs/node-lru-cache/commit/cd9806503c7abc9873fa1cc46a9ab7b43393a39c"><code>cd98065</code></a> 11.5.1</li> <li><a href="https://github.com/isaacs/node-lru-cache/commit/281f49d57e1cb53efc205d8e01b98a5762f73fb0"><code>281f49d</code></a> work with exactOptionalPropertyTypes</li> <li><a href="https://github.com/isaacs/node-lru-cache/commit/0adc7a5294db4a28f141b7e1edc90f0c4a2472a7"><code>0adc7a5</code></a> 11.5.0</li> <li><a href="https://github.com/isaacs/node-lru-cache/commit/4708153206daf822a3ad440ce47248b9cfbdb973"><code>4708153</code></a> add backgroundFetchSize option</li> <li><a href="https://github.com/isaacs/node-lru-cache/commit/9bed6dbbe2921db519e65630c0d1107ad9595db4"><code>9bed6db</code></a> formatting changelog</li> <li><a href="https://github.com/isaacs/node-lru-cache/commit/cd8f37b061eb142f2b9864c521019cc26f7c59e4"><code>cd8f37b</code></a> test: loosen test on onInsert</li> <li><a href="https://github.com/isaacs/node-lru-cache/commit/c440996b4ef1395d9f21fd7cde7332cf9377db5f"><code>c440996</code></a> 11.4.0</li> <li><a href="https://github.com/isaacs/node-lru-cache/commit/fdab1918f194f74b814ae23ec8588dd1989abec8"><code>fdab191</code></a> changelog 11.4</li> <li><a href="https://github.com/isaacs/node-lru-cache/commit/fbd958d038d225f0b8b29c4002df8491aa4e456c"><code>fbd958d</code></a> add cache to status type</li> <li><a href="https://github.com/isaacs/node-lru-cache/commit/451737cf4f82dc268b88530a559f900837261733"><code>451737c</code></a> fix several bugs related to background fetch edge cases</li> <li>Additional commits viewable in <a href="https://github.com/isaacs/node-lru-cache/compare/v7.10.1...v11.5.1">compare view</a></li> </ul> </details> <details> <summary>Install script changes</summary> <p>This version adds <code>prepare</code> script that runs during installation. Review the package contents before updating.</p> </details> <br /> --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Miodec <jack@monkeytype.com>
Added a quote from Witch Hat Atelier (manga). The quote is in English and sourced from the official English translation.
…8026) - Capitalization - Add another comment for `5000` ms - Change every `x min` to `x minutes` (could be changed the other way, just important to be consistent) - Update `resultsMismatchReport` comment to be `5 minutes` instead of `15 min`.
### Description Adding my personal layout: Vylet v4. This is the latest iteration of my original [Vylet](https://github.com/MightyAcas/vylet) layout. ### Checks - [ ] Adding quotes? - Make sure to follow the [quotes documentation](https://github.com/monkeytypegame/monkeytype/blob/master/docs/QUOTES.md) - [ ] Make sure to include translations for the quotes in the description (or another comment) so we can verify their content. - [ ] Adding a language? - Make sure to follow the [languages documentation](https://github.com/monkeytypegame/monkeytype/blob/master/docs/LANGUAGES.md) - [ ] Add language to `packages/schemas/src/languages.ts` - [ ] Add language to exactly one group in `frontend/src/ts/constants/languages.ts` - [ ] Add language json file to `frontend/static/languages` - [ ] Adding a theme? - Make sure to follow the [themes documentation](https://github.com/monkeytypegame/monkeytype/blob/master/docs/THEMES.md) - [ ] Add theme to `packages/schemas/src/themes.ts` - [ ] Add theme to `frontend/src/ts/constants/themes.ts` - [ ] (optional) Add theme css file to `frontend/static/themes` - [ ] Add some screenshots of the theme, especially with different test settings (colorful, flip colors) to your pull request - [x] Adding a layout? - [x] Make sure to follow the [layouts documentation](https://github.com/monkeytypegame/monkeytype/blob/master/docs/LAYOUTS.md) - [x] Add layout to `packages/schemas/src/layouts.ts` - [x] Add layout json file to `frontend/static/layouts` - [ ] Adding a font? - Make sure to follow the [fonts documentation](https://github.com/monkeytypegame/monkeytype/blob/master/docs/FONTS.md) - [ ] Add font file to `frontend/static/webfonts` - [ ] Add font to `packages/schemas/src/fonts.ts` - [ ] Add font to `frontend/src/ts/constants/fonts.ts` - [x] Check if any open issues are related to this PR; if so, be sure to tag them below. - [x] Make sure the PR title follows the Conventional Commits standard. (https://www.conventionalcommits.org for more info) - [x] Make sure to include your GitHub username prefixed with @ inside parentheses at the end of the PR title. <!-- label(optional scope): pull request title (@your_github_username) --> <!-- I know I know they seem boring but please do them, they help us and you will find out it also helps you. --> Closes # <!-- The issue(s) your PR resolves if any (delete if that is not the case) --> <!-- Please reference any issues and/or PRs related to your pull request --> <!-- Pro tip: you can mention an issue, PR, or discussion on GitHub by referencing its hash number, e.g.: [#1234](#1234) --> <!-- Pro tip: you can press . (dot or period) in the code tab of any GitHub repo to get access to GitHub's VS Code web editor. Enjoy! :) -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )