fix: keep OOReporter callbacks nonblocking#50
Merged
md0x merged 2 commits intoJul 17, 2026
Conversation
md0x
force-pushed
the
codex/fix-oo-reporter-callback-rerequests
branch
from
July 15, 2026 12:53
96dad6e to
6e02776
Compare
md0x
changed the title
md0x
marked this pull request as ready for review
July 15, 2026 12:57
md0x
force-pushed
the
codex/fix-oo-reporter-callback-rerequests
branch
from
July 15, 2026 14:08
6e02776 to
24cb620
Compare
md0x
changed the title
md0x
force-pushed
the
codex/fix-oo-reporter-callback-rerequests
branch
from
July 16, 2026 07:49
24cb620 to
8e611df
Compare
md0x
changed the title
md0x
force-pushed
the
codex/fix-oo-reporter-callback-rerequests
branch
from
July 16, 2026 08:35
8e611df to
2f70a54
Compare
md0x
force-pushed
the
codex/fix-oo-reporter-callback-rerequests
branch
from
July 16, 2026 09:02
2f70a54 to
d701100
Compare
chrismaree
reviewed
Jul 16, 2026
| try this.executeAutomaticRerequest(requestId, RerequestType.AutomaticDispute) { | ||
| request.automaticDisputeRerequestUsed = true; | ||
| return; | ||
| } catch {} |
Member
There was a problem hiding this comment.
do we want to emit something if this ever hits so we can police it with a monitor and ensure we are never hitting this outcome state?
Collaborator
Author
There was a problem hiding this comment.
Good point. I added AutomaticRerequestFailed(requestId, requestTimestamp, rerequestType) in df318a0 and emit it from both catch paths before RequestRerequestAllowed. This gives monitors a dedicated signal that an attempted automatic re-request actually failed, distinct from normal manual-gate openings such as disabled automation or a consumed automatic slot. The dispute and P4 regression tests assert the event, and all PR checks are passing.
chrismaree
approved these changes
Jul 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Automatic re-request failures could bubble through
priceDisputed()orpriceSettled()and revert the parent dispute or settlement. Run the replacement through a self-only external call, catch failures, and open the manual re-request gate instead.Failed attempts emit
AutomaticRerequestFailedfor monitoring. The automatic dispute slot is consumed only after a successful replacement.Test plan
forge test --match-path test/OOReporter.t.sol -vvv— 39 passedforge test --no-match-contract ".*Fork.*"— 77 passedforge build --sizes—OOReporterruntime 23,605 bytes