🐛 Fix footer links in new UI#4884
Draft
0AgentSmith wants to merge 6 commits into
Draft
Conversation
Modified to include source code and licence links
Modified to include source code and licence links
Modified to include source code and licence links Fixed: add GER phrase, delete ENG phrase
Contributor
Author
|
Wenn v-html und URLs in i18n jsons zu bad practice sind, bitte Bescheid sagen, dann lass ich mir was anderes einfallen |
MrKrisKrisu
requested changes
Jun 14, 2026
| "footer.legal": "Legal", | ||
| "footer.services": "Services", | ||
| "footer.source": "Quellcode lizenziert unter AGPLv3.", | ||
| "footer.source": "<a href=\"https://github.com/traewelling/traewelling\" target=\"_blank\" class=\"link link-hover\">Quellcode</a> lizenziert unter <a href=\"https://www.gnu.org/licenses/agpl-3.0.html\" target=\"_blank\" class=\"link link-hover\">AGPLv3</a>.", |
Member
There was a problem hiding this comment.
Bitte HTML in den Language Files vermeiden. v-html macht uns angreifbar für XSS und sollte vorher sanitized werden.
| "footer.legal": "Legal", | ||
| "footer.services": "Services", | ||
| "footer.source": "Source code licensed under AGPLv3.", | ||
| "footer.source": "<a href=\"https://github.com/traewelling/traewelling\" target=\"_blank\" class=\"link link-hover\">Source code</a> licensed under <a href=\"https://www.gnu.org/licenses/agpl-3.0.html\" target=\"_blank\" class=\"link link-hover\">AGPLv3</a>.", |
Member
There was a problem hiding this comment.
Bitte HTML in den Language Files vermeiden. v-html macht uns angreifbar für XSS und sollte vorher sanitized werden.
0AgentSmith
marked this pull request as draft
June 15, 2026 17:03
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should fix #4883