Conversation
Contributor
Author
|
그 x 버튼 있는 제거 가능한 키워드의 버튼 클릭 영역을 제가 기획팀에 늦게 여쭤보아... 이 부분 확답오면 맞춰서 작업하고 머지 하겠습니닷 |
- WhiteRemovableKeywordChip
- White와는 배경색 차이 존재
- 앞에 Capsule 추가 (Rectangle과 구분 목적)
Member
|
@onesunny2 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
💡 Issue
#109
💭 Summary
다양한 키워드 칩 컴포넌트를 추가하고, 칩 이름을 역할 기반에서 생김새 기반으로 일관성 있게 정리했습니다. Figma 디자인에서 새로 받은 2종(
PrimaryRemovable,RectangleSelectable)도 함께 구현했습니다.🔑 Key Changes
키워드칩 6종 구성
SoftKeywordChipCountedKeywordChipCapsuleSelectableKeywordChipRectangleSelectableKeywordChipWhiteRemovableKeywordChipPrimaryRemovableKeywordChip네이밍 정책 변경 (역할 기반 → 생김새 기반)
LibraryKeywordChip→SoftKeywordChipPreferenceKeywordChip→CountedKeywordChipFilterKeywordChip→ 1차SelectableKeywordChip→ 2차CapsuleSelectableKeywordChip(Rectangle 형태 추가되면서 모양 prefix로 구분)SearchKeywordChip→ 1차CloseKeywordChip→ 2차WhiteRemovableKeywordChip(색 prefix로 신규PrimaryRemovable과 구분)기타 정리
action으로 통일 (onTap/onRetry등을 제거)icKeywordCancel이미지 에셋 추가WSSComponent의 중복.lottie의존성 제거 (Preview 빌드 시Unexpected duplicate tasks — ProcessXCFramework Lottie.xcframework에러 해결)