Skip to content

#769 Prepare utils for Header component#817

Merged
NoelDeMartin merged 5 commits into
SolidOS:stagingfrom
NoelDeMartin:769-header
Jul 2, 2026
Merged

#769 Prepare utils for Header component#817
NoelDeMartin merged 5 commits into
SolidOS:stagingfrom
NoelDeMartin:769-header

Conversation

@NoelDeMartin

@NoelDeMartin NoelDeMartin commented Jun 25, 2026

Copy link
Copy Markdown
Member

@NoelDeMartin NoelDeMartin changed the title 769 header #769 Header component Jun 25, 2026
@NoelDeMartin NoelDeMartin force-pushed the 769-header branch 2 times, most recently from be5cccc to 582cfda Compare June 29, 2026 14:21
@NoelDeMartin NoelDeMartin requested a review from timea-solid June 29, 2026 14:23

@timea-solid timea-solid left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice to see it come together more and more like the menu items, the mobile breakpoint again.
Do you think this will solve the duplicated loading of components?

Comment thread src/lib/components/traits/InputTrait.ts
@NoelDeMartin NoelDeMartin force-pushed the 769-header branch 2 times, most recently from 89d4817 to 575e1fa Compare July 1, 2026 14:49
@NoelDeMartin NoelDeMartin changed the title #769 Header component #769 Prepare utils for Header component Jul 1, 2026
@NoelDeMartin NoelDeMartin marked this pull request as ready for review July 1, 2026 15:01
- SVG obtained from solidproject.org and cleaned up with svgomg.net
- We're wrapping this custom icon as a normal component because it's easier, if we end up with a lot of these icon components we should consider moving them to some specialized solid-ui/icons/ export paths.
- Header component will be implemented in solid-panes instead
- Implement customizable items menu in Account component
- Add new design tokens
- Remove v2 header and feature flags
- Defined breakpoints (only mobile for now)
- Exported breakpoints.css for library consumers
@NoelDeMartin NoelDeMartin merged commit f6bf3c7 into SolidOS:staging Jul 2, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove DESIGN_SYSTEM_HEADER_ACCOUNT feature toggle Replace Header with Design System components

2 participants