Refactor: Refactor systems and behavior#46
Conversation
|
This also builds if used as an external library here. I did not yet make a release yet using this branch as a dependency, but if I remember I'll update this with a link to the android release. |
This comment was marked as resolved.
This comment was marked as resolved.
|
@leomeinel First of all, thank you very much for separating it into multiple PRs 🙌🏼, now it is very easy to review. Second, in what order should I merge the PRs? 😅 |
Of course, I hesitated at first but I also think that this is better. I'm pretty sure that it is impossible to avoid conflicts, but I'd recommend merging in this order (fixes first):
*I'll resolve the merge conflicts asap after the other branches have been merged, just leave a comment on the conflicting PR. |
|
Thank you so much, really. For now, I've merged the ones that are easier to review. When I get home, I'll calmly review the remaining ones |
Perfect, that is awesome! Thank you very much for this crate and the reviews :) |
This comment was marked as resolved.
This comment was marked as resolved.
caec19e to
d9d2514
Compare
|
The update for Bevy 0.17 is already merged; we just need you to resolve the conflicts in 0.18 and then we'll merge the last two. Thank you so much! |
Perfect, I'm very very happy about all the changes having been approved. I'm pretty sure that all conflicts in #42 and here are resolved correctly now :) |
We have also switched to Rust edition 2024. This dramatically improves readability by removing indents and simplifying variable assignments etc. I've also added docs to code that I've touched.
|
The last force push was just to rebase on top of the current main without any changes. |
|
Awesome, thanks for merging all of this and all the work you have put into the reviews :) |
|
Hey @leomeinel they're finally all merged. Thank you so much for your help 🙌🏼 The project was really behind schedule. Thanks, friend, for all your trouble, and sorry for the delay 😶🌫️ |
You're welcome. I was really happy to have found this crate and it saved me a lot of work, therefore it was only appropriate to contribute 🥇 |
This currently includes other rebased commits of mine and therefore is quite cluttered. I did definetly not want to have to remerge this 1/2 times, therefore I just rebased on top of a branch with all PRs applied.
The following commits have to be merged before this can be merged:
Afterwards only the last commit can be merged on its own (I hope).
This is the successor of #40