Conversation
…ons in Get-PowerShellPortable. Refactor platform checks and OS-specific commands with more efficient handling. Combine redundant Linux and macOS extraction code blocks and dispose of streams properly.
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
Up to standards ✅🟢 Issues
|
Contributor
There was a problem hiding this comment.
Pull request overview
Refactors Get-PowerShellPortable to improve reliability and cross-platform behavior when downloading/extracting the latest PowerShell portable archive.
Changes:
- Adds
-Pathdirectory validation and improves help text/parameter descriptions. - Refactors platform detection and adjusts OS-specific behavior (e.g., Windows-only
Unblock-File). - Consolidates Linux/macOS gzip extraction into a single
try/finallydisposal flow and moves status messages to the Information stream.
…ecks The module declares PowerShellVersion = '5.1', so the ?. operator (PS 7+ only) must not be used. Initialize streams to \ before the try block and use explicit if-checks in the finally block. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Specify Read/FileShare.Read for the source stream and Write/FileShare.None for the target stream to follow least-privilege and avoid potential UnauthorizedAccessException on restricted filesystems. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refactors \Get-PowerShellPortable\ with several quality improvements:
Changes