Add detailed error information for filtered_fwrite failures#780
Open
UMAHunter wants to merge 2 commits into
Open
Add detailed error information for filtered_fwrite failures#780UMAHunter wants to merge 2 commits into
UMAHunter wants to merge 2 commits into
Conversation
steadytao
requested changes
Jun 6, 2026
Member
steadytao
left a comment
There was a problem hiding this comment.
Writing this diagnostic to stdout when stderr fails looks risky; stdout may be normal output or protocol data. I think this should avoid the alternate stream fallback.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I frequently see the following error in our local
line 244 and 245 in log.c is:
It invokes logging message, but not detailed enough to diagnose how fwrite() fails. This patch should output the errno to stderr or stdout(avoid the 'f' in the previous line) to see what fwrite() happens.