fix(video-conference): enable ring notifications for group calls and channels#40887
Open
rish106-hub wants to merge 2 commits into
Open
Conversation
Contributor
|
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
🦋 Changeset detectedLatest commit: 894ad02 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
WalkthroughThis PR adds incoming call ring notifications for group video conferences (channels and group DMs) on Rocket.Chat Community Edition. Client-side changes distinguish group calls from 1-1 calls via an ChangesGroup Call Ring Support
🎯 3 (Moderate) | ⏱️ ~20 minutes
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Warning Review ran into problems🔥 ProblemsErrors were encountered while retrieving linked issues. Errors (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
🧹 Nitpick comments (2)
apps/meteor/server/configuration/videoConference.ts (1)
5-10: ⚡ Quick winRemove implementation comments per repository guideline.
Lines 5-10 add explanatory comments in implementation code; this conflicts with the TS/JS guideline to avoid code comments in implementation. Prefer self-descriptive naming and keep rationale in PR/ADR instead.
As per coding guidelines: “
**/*.{ts,tsx,js}... Avoid code comments in the implementation”.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@apps/meteor/server/configuration/videoConference.ts` around lines 5 - 10, Remove the explanatory implementation comments added in the videoConference.ts block (the multi-line rationale about CE/EE, handler priorities, and the ringing-cap behavior) and instead rely on a clear, self-descriptive identifier for the related value (e.g., the ringing cap constant or handler registration where priority is set) so the code reads intent without comments; move the detailed rationale into the PR description or an ADR. Ensure the constant/handler name clearly indicates it mirrors the EE limit and the priority relationship so no inline comments are required.Source: Coding guidelines
apps/meteor/client/lib/VideoConfManager.ts (1)
188-190: ⚡ Quick winRemove inline implementation comments in this block.
Line 188 to Line 190 adds implementation comments; this file pattern requires avoiding code comments in implementation. Prefer self-explanatory code structure/naming instead.
As per coding guidelines, "Avoid code comments in the implementation."
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@apps/meteor/client/lib/VideoConfManager.ts` around lines 188 - 190, Remove the inline implementation comments inside the block guarded by callData.isGroupCall; instead make the intent explicit via code (e.g., use a clearly named helper or boolean such as isGroupCall or joinDirectlyForGroupCalls and/or extract the group-join behavior into a descriptively named function like handleGroupJoin) so the code reads self-documentingly and the inline comments can be deleted to comply with the "no implementation comments" guideline.Source: Coding guidelines
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@apps/meteor/client/lib/VideoConfManager.ts`:
- Around line 188-190: Remove the inline implementation comments inside the
block guarded by callData.isGroupCall; instead make the intent explicit via code
(e.g., use a clearly named helper or boolean such as isGroupCall or
joinDirectlyForGroupCalls and/or extract the group-join behavior into a
descriptively named function like handleGroupJoin) so the code reads
self-documentingly and the inline comments can be deleted to comply with the "no
implementation comments" guideline.
In `@apps/meteor/server/configuration/videoConference.ts`:
- Around line 5-10: Remove the explanatory implementation comments added in the
videoConference.ts block (the multi-line rationale about CE/EE, handler
priorities, and the ringing-cap behavior) and instead rely on a clear,
self-descriptive identifier for the related value (e.g., the ringing cap
constant or handler registration where priority is set) so the code reads intent
without comments; move the detailed rationale into the PR description or an ADR.
Ensure the constant/handler name clearly indicates it mirrors the EE limit and
the priority relationship so no inline comments are required.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 61b9fad6-b1b4-4ad1-a331-7249680324f2
📒 Files selected for processing (4)
.changeset/fix-conference-call-ring.mdapps/meteor/client/lib/VideoConfManager.tsapps/meteor/server/configuration/index.tsapps/meteor/server/configuration/videoConference.ts
📜 Review details
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: cubic · AI code reviewer
🧰 Additional context used
📓 Path-based instructions (1)
**/*.{ts,tsx,js}
📄 CodeRabbit inference engine (.cursor/rules/playwright.mdc)
**/*.{ts,tsx,js}: Write concise, technical TypeScript/JavaScript with accurate typing in Playwright tests
Avoid code comments in the implementation
Files:
apps/meteor/server/configuration/videoConference.tsapps/meteor/server/configuration/index.tsapps/meteor/client/lib/VideoConfManager.ts
🧠 Learnings (6)
📚 Learning: 2026-02-26T19:25:44.063Z
Learnt from: gabriellsh
Repo: RocketChat/Rocket.Chat PR: 38778
File: packages/ui-voip/src/providers/useMediaSession.ts:192-192
Timestamp: 2026-02-26T19:25:44.063Z
Learning: In the Rocket.Chat repository, do not reference Biome lint rules in code review feedback. Biome is not used even if biome.json exists; only reference Biome rules if there is explicit, project-wide usage documented. For TypeScript files, review lint implications without Biome guidance unless the project enables Biome rules.
Applied to files:
apps/meteor/server/configuration/videoConference.tsapps/meteor/server/configuration/index.tsapps/meteor/client/lib/VideoConfManager.ts
📚 Learning: 2026-02-26T19:25:44.063Z
Learnt from: gabriellsh
Repo: RocketChat/Rocket.Chat PR: 38778
File: packages/ui-voip/src/providers/useMediaSession.ts:192-192
Timestamp: 2026-02-26T19:25:44.063Z
Learning: In this repository (RocketChat/Rocket.Chat), Biome lint rules are not used even if a biome.json exists. When reviewing TypeScript files (e.g., packages/ui-voip/src/providers/useMediaSession.ts), ensure lint suggestions do not reference Biome-specific rules. Rely on general ESLint/TypeScript lint rules and project conventions instead.
Applied to files:
apps/meteor/server/configuration/videoConference.tsapps/meteor/server/configuration/index.tsapps/meteor/client/lib/VideoConfManager.ts
📚 Learning: 2026-05-06T12:21:44.083Z
Learnt from: juliajforesti
Repo: RocketChat/Rocket.Chat PR: 40256
File: apps/meteor/client/components/CreateDiscussion/CreateDiscussion.tsx:121-149
Timestamp: 2026-05-06T12:21:44.083Z
Learning: Field wrappers in rocket.chat/fuselage-forms (Field, FieldLabel, FieldRow, FieldError, FieldHint) auto-create htmlFor/id associations, aria-describedby, and role="alert" for errors. Do not manually set htmlFor, id, aria-describedby, or role attributes when using these wrappers. This automatic wiring does not apply to plain rocket.chat/fuselage components, which require explicit ID wiring per the accessibility docs. In code reviews, prefer using fuselage-forms wrappers for form fields and verify there is no unnecessary manual ID/aria wiring in files that use these wrappers. If a component uses plain fuselage components, ensure proper id wiring as per docs.
Applied to files:
apps/meteor/server/configuration/videoConference.tsapps/meteor/server/configuration/index.tsapps/meteor/client/lib/VideoConfManager.ts
📚 Learning: 2026-03-16T21:50:37.589Z
Learnt from: amitb0ra
Repo: RocketChat/Rocket.Chat PR: 39676
File: .changeset/migrate-users-register-openapi.md:3-3
Timestamp: 2026-03-16T21:50:37.589Z
Learning: For changes related to OpenAPI migrations in Rocket.Chat/OpenAPI, when removing endpoint types and validators from rocket.chat/rest-typings (e.g., UserRegisterParamsPOST, /v1/users.register) document this as a minor changeset (not breaking) per RocketChat/Rocket.Chat-Open-API#150 Rule 7. Note that the endpoint type is re-exposed via a module augmentation .d.ts in the consuming package (e.g., packages/web-ui-registration/src/users-register.d.ts). In reviews, ensure the changeset clearly states: this is a non-breaking change, the major version should not be bumped, and the changeset reflects a minor version bump. Do not treat this as a breaking change during OpenAPI migrations.
Applied to files:
.changeset/fix-conference-call-ring.md
📚 Learning: 2026-02-10T16:32:42.586Z
Learnt from: tassoevan
Repo: RocketChat/Rocket.Chat PR: 38528
File: apps/meteor/client/startup/roles.ts:14-14
Timestamp: 2026-02-10T16:32:42.586Z
Learning: In Rocket.Chat's Meteor client code, DDP streams use EJSON and Date fields arrive as Date objects; do not manually construct new Date() in stream handlers (for example, in sdk.stream()). Only REST API responses return plain JSON where dates are strings, so implement explicit conversion there if needed. Apply this guidance to all TypeScript files under apps/meteor/client to ensure consistent date handling in DDP streams and REST responses.
Applied to files:
apps/meteor/client/lib/VideoConfManager.ts
📚 Learning: 2026-05-11T20:30:35.265Z
Learnt from: tassoevan
Repo: RocketChat/Rocket.Chat PR: 40480
File: apps/meteor/client/meteor/startup/accounts.ts:59-61
Timestamp: 2026-05-11T20:30:35.265Z
Learning: In Rocket.Chat’s Meteor client code, when calling `dispatchToastMessage` with `{ type: 'error' }`, pass the raw caught error object as `message` without manual normalization. `dispatchToastMessage` is designed to accept `message: unknown` for error toasts, so avoid converting errors to strings (e.g., `String(error)`) or extracting `error.message` before passing them.
Applied to files:
apps/meteor/client/lib/VideoConfManager.ts
🔇 Additional comments (4)
apps/meteor/server/configuration/videoConference.ts (1)
13-23: LGTM!apps/meteor/server/configuration/index.ts (1)
15-15: LGTM!apps/meteor/client/lib/VideoConfManager.ts (1)
21-21: LGTM!Also applies to: 191-196, 515-516, 595-610, 635-646
.changeset/fix-conference-call-ring.md (1)
1-23: LGTM!
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixed missing ring notifications for group video conference calls. Group calls (channels and group DMs) sent a
ringaction to room members but the client never handled it — no incoming call popup or ringtone shown.Additionally, accepting a group call incorrectly triggered the 1-1 direct-call accept/confirm handshake, causing a 5-second timeout error.
Changes
Client (VideoConfManager.ts):
ringcase in onVideoConfNotification → new onGroupCallRing methodServer (videoConference.ts):
Test plan
Closes #34910
Summary by CodeRabbit