Refactor internal request state into DispatchContext#165
Merged
Conversation
Replace the old local Request wrapper with an explicitly internal DispatchContext built around the PSR-7 server request. Changes: - rename src/Request.php to src/DispatchContext.php - keep the PSR request as the canonical transport object via $request - replace shadow request fields with explicit context accessors and mutators for effective method/path - rename Router::$request to Router::$context - rename Router::dispatchRequest() to Router::dispatchContext() - update router dispatch flow, routes, and routines to accept DispatchContext instead of the misleading Request type - migrate tests and stubs to the new terminology and API - add router regressions for empty global OPTIONS handling and Router stringification through the active dispatch context Verification: - composer qa - changed executable lines verified at 100% coverage
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #165 +/- ##
============================================
+ Coverage 96.46% 97.14% +0.67%
- Complexity 441 445 +4
============================================
Files 27 27
Lines 1076 1085 +9
============================================
+ Hits 1038 1054 +16
+ Misses 38 31 -7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the old local Request wrapper with an explicitly internal DispatchContext built around the PSR-7 server request.
Changes:
Verification: