Tighten HTTP content negotiation semantics#161
Merged
Conversation
Modernize the Accept* negotiation layer so it behaves more like HTTP clients expect while keeping the implementation centralized and small. Changes: - make missing Accept, Accept-Language, Accept-Charset, and Accept-Encoding headers permissive by default - normalize negotiated header tokens before matching so parameterized media types like application/json; charset=utf-8 match cleanly - merge Vary metadata across chained negotiators instead of overwriting it - keep extension-based negotiation strict to the request URI while allowing wildcard fallback for normal header-based provisions - replace deprecated SplObjectStorage::contains() lookups with offsetExists() in negotiation routines - add regression tests for permissive missing Accept headers, parameterized Accept matching, merged Vary headers, and real 406 failures Verification: - composer qa
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #161 +/- ##
=========================================
Coverage ? 96.13%
Complexity ? 411
=========================================
Files ? 27
Lines ? 1010
Branches ? 0
=========================================
Hits ? 971
Misses ? 39
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modernize the Accept* negotiation layer so it behaves more like HTTP clients expect while keeping the implementation centralized and small.
Changes:
Verification: