fix: Ignore failure propagation in collection member that is ignored in filters and reject failure propagation without common primary key

[Moritz Potthoff (MoritzPotthoffQC)]

Motivation

Opposed to the docs, for a member that is ignored in filters, the failure propagation property is currently not ignored.

Additionally, we should reject collections if they have a failure-propagating member (not ignored) but no common primary key. Like for filters, entries that are filtered out of a failure-propagating member would be propagated across members, which does not work without common primary key.

Changes

• Ignore failure propagation for members that are ignored in filters
• Extend the criteria for rejection
• Add tests

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (e4353e7) to head (0e1d269).

Additional details and impacted files

@@            Coverage Diff            @@
##              main      #370   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           56        56           
  Lines         3506      3507    +1     
=========================================
+ Hits          3506      3507    +1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[Copilot]

Pull request overview

This PR tightens collection validation to reject collections that cannot correctly apply cross-member behavior (filters and row-failure propagation) due to missing overlapping primary keys, and adds a regression test for the new rejection case.

Changes:

• Extend the metaclass validation to require an overlapping primary key when any non-ignored member enables row-failure propagation (in addition to the existing “filters present” condition).
• Add a test ensuring collections with propagate_row_failures=True but no common primary key are rejected.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
dataframely/collection/_base.py	Expands the “must have overlapping primary key” validation to cover failure-propagation scenarios.
tests/collection/test_implementation.py	Adds a regression test for failure propagation without a common primary key.

[Copilot]

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

[Oliver Borchert (borchero)]

Thank you!