Sparse pullback for big performance gain#2170
Open
unalmis wants to merge 98 commits into
Open
Conversation
Co-authored-by: Kaya Unalmis <kayaunalmis@proton.me>
Co-authored-by: Kaya Unalmis <kayaunalmis@proton.me>
f0uriest
reviewed
Jun 3, 2026
unalmis
requested review from
ddudt,
dpanici,
f0uriest and
rahulgaur104
and removed request for
ddudt,
dpanici,
f0uriest and
rahulgaur104
June 8, 2026 21:53
ddudt
reviewed
Jun 15, 2026
ddudt
left a comment
Collaborator
There was a problem hiding this comment.
I haven't reviewed all the code yet, but I think this introduces some breaking changes. I'm not sure what the best solution is: ideally we would keep support for forward mode, but we at least need to add more error handling.
Collaborator
Author
Merged
rahulgaur104
removed their request for review
June 19, 2026 08:53
Collaborator
Author
|
@ddudt @daniel-dudt it works in forward mode now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bounce1doptimization.is_reshaped,is_fourier) that users said were confusing (backwards compatible) as well as the developer flagsBref,Lrefthat should not be there.pitch_batch_sizewas getting ignored. This fixes that by addingstrip_dim0flag tobatch_map.notes