Security: reject legacy short access keys on RTMP and stats auth#84
Closed
cursor[bot] wants to merge 2 commits into
Closed
Security: reject legacy short access keys on RTMP and stats auth#84cursor[bot] wants to merge 2 commits into
cursor[bot] wants to merge 2 commits into
Conversation
… paths HTTP stream creation already enforces 32+ character publish/play/stats keys, but RTMP authorization and public stats lookups still accepted shorter values present in upgraded SQLite databases. Reject sub-minimum keys at lookup time so grandfathered weak keys cannot be brute-forced over RTMP or the rate-limited /stats endpoints. Co-authored-by: Alexander Wagner <info@alexanderwagnerdev.com>
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Security review summary
Scheduled scan at commit
40e5850found 1 new medium-severity issue (issue #83) and ships a fix on this branch.MEDIUM — Legacy sub-32-character access keys remain valid on RTMP and stats authentication paths (
src/db.rs)is_valid_access_key()inkeygen.rsand reject sub-minimum keys instream_find_by_*/viewer_find_by_play_keylookups used by RTMP auth and/statsVerification
cargo test— 94 tests passinglegacy_short_access_keys_are_rejected_at_lookupregression testOperator follow-up
Deployments that previously created short custom keys must rotate publish/play/stats keys via the API after upgrading; rejected legacy keys will fail auth until rotated.
Need help on this PR? Tag
/codesmithwith what you need. Autofix is disabled.