Add "Override local binding" to HTTP Sender#333
Conversation
jbeckers
requested review from
a team,
NicoPiel,
gibson9583,
jonbartels,
kayyagari,
kpalang,
mgaffigan and
ssrowe
|
No AI was used in the making of this PR, only good ol' manual copy-paste. |
|
I tested this in a podman container with 2 bridged networks. Results of "Test connection":
|
|
Sending a message IP 10.89.0.3 override |
|
This PR probably needs some unit tests. I'll work on that at the end of this week. |
jbeckers
force-pushed
the
feature/332-add-override-local-binding-to-http-sender
branch
from
fba0393 to
4221c0a
Compare
There was a problem hiding this comment.
Pull request overview
Adds an “Override Local Binding” option to the HTTP Sender so outbound HTTP connections (and the “Test Connection” action) can bind to a specific local source IP, aligning HTTP Sender capabilities with other connectors.
Changes:
- Added
overrideLocalBinding+localAddressproperties to HTTP dispatcher settings and wired them through the client UI. - Applied Apache HTTP Client
RequestConfig.Builder#setLocalAddress(...)when override is enabled. - Extended connection testing to optionally bind a local address during socket connection tests.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| server/src/com/mirth/connect/server/util/ConnectorUtil.java | Adds an overload to allow connection tests to bind to a local address. |
| server/src/com/mirth/connect/connectors/http/HttpDispatcherProperties.java | Introduces new HTTP sender properties for overriding local binding and storing a local address. |
| server/src/com/mirth/connect/connectors/http/HttpDispatcher.java | Configures Apache HTTP client requests to bind to the configured local address when enabled. |
| server/src/com/mirth/connect/connectors/http/HttpConnectorServlet.java | Updates “Test Connection” to optionally bind the local address when override is enabled. |
| client/src/com/mirth/connect/connectors/http/HttpSender.java | Adds UI controls for “Override Local Binding” and “Local Address”, plus validation/reset behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
mgaffigan
left a comment
mgaffigan
left a comment
There was a problem hiding this comment.
Looks like a nice feature! I think some additional work is required to correct the velocity issue, and to fix the DCO check, but after that it looks good to me.
Thanks for sharing!
Test Results 111 files 214 suites 6m 28s ⏱️ Results for commit e8ddbc3. ♻️ This comment has been updated with latest results. |
mgaffigan
left a comment
mgaffigan
left a comment
There was a problem hiding this comment.
@jbeckers - looks all good. Can you fix the DCO? Need that before we can approve.
kpalang
left a comment
kpalang
left a comment
There was a problem hiding this comment.
Some changes/clarifications required.
Review comments formatted as conventional comments
Signed-off-by: Joachim Beckers <joachim.beckers@nexuzhealth.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Signed-off-by: Joachim Beckers <joachim@jbeckers.be> Signed-off-by: Joachim Beckers <joachim.beckers@nexuzhealth.com>
Signed-off-by: Joachim Beckers <joachim.beckers@nexuzhealth.com>
Signed-off-by: Joachim Beckers <joachim.beckers@nexuzhealth.com>
…formed() Signed-off-by: Joachim Beckers <joachim.beckers@nexuzhealth.com>
Signed-off-by: Joachim Beckers <joachim.beckers@nexuzhealth.com>
jbeckers
force-pushed
the
feature/332-add-override-local-binding-to-http-sender
branch
from
b6f58bd to
e8ddbc3
Compare
I force pushed the amended commits |
|
Thanks everyone! I'd love it if this change could land in 4.6.0-rc2. But I guess an RC shouldn't contain any new features? |
Fixes #332