Update deploy workflows for Nordix Artifactory#9
Conversation
| push: | ||
| tags: | ||
| - v5.3.[0-9]+ | ||
| - 'v5.3.*-est-*' |
There was a problem hiding this comment.
This is too permissive, can you replace the asterisks with digits?
There was a problem hiding this comment.
updated to 'v5.3.[0-9]+-est[-]?[0-9]*'
| push: | ||
| branches: | ||
| - 5.3.x | ||
| - 'v5.3.*-est-*' |
There was a problem hiding this comment.
| - 'v5.3.*-est-*' | |
| - 'v5.3.\d{1,}-est' |
I'm not sure if there are plans to have a v5.3.39-est-someFeature branch, but I think the regex should be more specific
There was a problem hiding this comment.
This regex might work better v5.3.[0-9]+-est[-]?[a-z0-9]*
There was a problem hiding this comment.
updated to 'v5.3.[0-9]+-est[-]?[0-9]*'
| signing-key: ${{ secrets.GPG_PRIVATE_KEY }} | ||
| signing-passphrase: ${{ secrets.GPG_PASSPHRASE }} |
There was a problem hiding this comment.
I've added this back in
| push: | ||
| tags: | ||
| - v5.3.[0-9]+ | ||
| - 'v5.3.*-est-*' |
There was a problem hiding this comment.
| - 'v5.3.*-est-*' | |
| - 'v5.3.\d{1,}-est' |
I'm not sure if there are plans to have a v5.3.39-est-someFeature branch, but I think the regex should be more specific
There was a problem hiding this comment.
That would need to be added at the end as well. We could have more than one version of patch
There was a problem hiding this comment.
That would need to be added at the end as well. We could have more than one version of patch
Is this what you are thinking of (v5.3.\d{1,}-est)(-.*){0,1}?
There was a problem hiding this comment.
are '\d', '{', '}' allowed for filters?
https://docs.github.com/en/actions/reference/workflows-and-actions/workflow-syntax#filter-pattern-cheat-sheet
There was a problem hiding this comment.
This regex might work v5.3.[0-9]+-est[-]?[a-z0-9]*
There was a problem hiding this comment.
The last part could be just digits
There was a problem hiding this comment.
something like 'v5.3.*-est-[0-9]' should work (if we don't intend to go past '..est-9') but I can't see how you could allow single or double digits after the 'v5.3.'.
? or [0-9] would allow one digit, ?? would allow two digits but only * will allow either.
There was a problem hiding this comment.
something like 'v5.3.*-est-[0-9]' should work (if we don't intend to go past '..est-9') but I can't see how you could allow single or double digits after the 'v5.3.'. ? or [0-9] would allow one digit, ?? would allow two digits but only * will allow either.
?: Matches zero or one of the preceding character.
Using just ? for the version match would be wrong
| signing-key: ${{ secrets.GPG_PRIVATE_KEY }} | ||
| signing-passphrase: ${{ secrets.GPG_PASSPHRASE }} |
There was a problem hiding this comment.
I'll add this back in.
| create-github-release: | ||
| name: Create GitHub Release | ||
| needs: | ||
| - build-and-stage-release | ||
| - promote-release | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - name: Check Out Code | ||
| uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1 | ||
| - name: Create GitHub Release | ||
| uses: ./.github/actions/create-github-release | ||
| with: | ||
| milestone: ${{ needs.build-and-stage-release.outputs.version }} | ||
| token: ${{ secrets.GH_ACTIONS_REPO_TOKEN }} |
There was a problem hiding this comment.
Is the plan to only publish on Artifactory and not do any additional releases?
There was a problem hiding this comment.
all 'est-x' releases will be on artifactory. After v5.3.39-est-1 is released and published, ..est-2 will be released and published, ..est-3, ..est-4, ... Same for v5.3.40-est-1, ..v5.3.40-est-2... if required
|
Nit: update name for systemProp.user.name in .github/actions/prepare-gradle-build/action.yml |
stecurran-est
force-pushed
the
update/deploy-workflow
branch
from
b018de6 to
02ad9fe
Compare
- Target Nordix Artifactory
- Update github actions to reference Nordix
- Update branch/tag patterns to match v5.3.x-est(-x) naming
- Remove Spring-specific steps (verification, Maven
Central sync, promotion, GitHub release, notifications)
- Remove Develocity access key dependency
stecurran-est
force-pushed
the
update/deploy-workflow
branch
from
02ad9fe to
614dd50
Compare
3 participants
Description
promotion, GitHub release, notifications)