Use ROSCO DISCON schema for SU default parameters#474
Open
dzalkind wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
DLC 3.1/3.2/3.3 (start-up cases) hard-coded
SU_FW_MinDuration,SU_RotorSpeedThresh,SU_RotorSpeedCornerFreq,SU_LoadStages_N,SU_LoadStages,SU_LoadRampDuration, andSU_LoadHoldDurationindlc_generator.pywith values that did not match ROSCO's own startup tuning defaults (e.g.SU_FW_MinDuration=40vs ROSCO's200,SU_RotorSpeedThresh=0.02vs0.52). With these mismatched defaults, the controller left the free-wheel state too soon, before the rotor had picked up enough speed, which upset the startup control response.rosco_default()helper that readsSU_*defaults directly from the ROSCO toolbox schema (rosco.toolbox.inputs.toolbox_schema), so DLC start-up defaults always stay in sync with ROSCO's own tuning defaults instead of being duplicated/hard-coded in WEIS.generate_3p1,generate_3p2, andgenerate_3p3to pull allSU_*defaults fromrosco_default().Type of change
Testing
weis/dlc_driver/test/test_DLC_generator.py, which passes.SU_FW_MinDuration=200,SU_RotorSpeedThresh=0.52,SU_RotorSpeedCornerFreq=0.41888,SU_LoadStages_N=2,SU_LoadStages=[0.2,1.0],SU_LoadRampDuration=[100,100],SU_LoadHoldDuration=[200,100]).Checklist