Redesign Squarelet billing pages#716
Conversation
This still contains a lot of Claude written code which I need to review before being ready for wider review
mitchelljkotler
left a comment
mitchelljkotler
left a comment
There was a problem hiding this comment.
This looks like it is still under development, let me know if you have any questions
| context["subscriptions"] = subscriptions | ||
|
|
||
| # Get card on file | ||
| customer = self.object.customer() |
There was a problem hiding this comment.
Having to write this check out every time is not good - I left this in my branch, but I am going to update this so customer.card just returns the actual card object you want - I will let you know when that is merged in so you can update on your branch
| form_class = UpdateSubscriptionFrequencyForm | ||
| template_name = "subscriptions/update_subscription_frequency.html" | ||
|
|
||
| def get_queryset(self): |
There was a problem hiding this comment.
You shouldn't need to override get_queryset or get_object here - it should do the right thing if you pass in a slug as a kwarg from the URL
There was a problem hiding this comment.
The route 404s when I remove these overrides. The URL also contains the subscription pk, could that be the issue?
| form_class = CancelSubscriptionForm | ||
| template_name = "subscriptions/cancel_subscription.html" | ||
|
|
||
| def get_queryset(self): |
|
@mitchelljkotler Thanks for reviewing. The only piece of this I haven't tackled yet is switching from a monthly plan to annual or vice versa. I'm happy to take a crack at it if you can lay out the general approach for me. |
mitchelljkotler
force-pushed
the
update-payment-handling-multiple-subscriptions
branch
from
452a3ad to
2b41be1
Compare
3 participants
No description provided.