Fix missaligned snapping crosshair due to broken property binding#4601
Merged
Conversation
📦 Build Artifacts Ready
|
tomasMizera
reviewed
Jul 15, 2026
Withalion
force-pushed
the
bugfix/missaligned-snapping-crosshair
branch
from
July 16, 2026 13:36
12d1e8f to
69a083d
Compare
Coverage Report for CI Build 29739170569Warning No base build found for commit Coverage: 59.09%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsRequires a base build to compare against. How to fix this → Coverage Stats
💛 - Coveralls |
📦 Build Artifacts Ready
|
📦 Build Artifacts Ready
|
tomasMizera
approved these changes
Jul 20, 2026
📦 Build Artifacts Ready
|
📦 Build Artifacts Ready
|
Testing noteThe application behaves as expected. ✅ Application: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After migrating to newer Qt version recording crosshair didn't properly snap to vertices etc. This PR fixes the issue and after the crosshair snaps to vertex, it remains "sticky" for a small distance.
Old
screen-20260626-103045-1782462623918.mp4
New
Screencast_20260714_190952.mp4
Thanks @harminius for catching this :)