fix: RetroAchievements identification for custom Paks and multi-system emulators#775
Open
apommel wants to merge 1 commit into
Open
fix: RetroAchievements identification for custom Paks and multi-system emulators#775apommel wants to merge 1 commit into
apommel wants to merge 1 commit into
Conversation
Member
|
Looks good to me, what do you think @clintonium-119? |
|
LGTM 💯 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the RetroAchievements integration relies on a mapping of the NextUI emulator tags (in
ra_consoles.h) to identify the running console and then the game. If the console is not detected, the integration stops the identification. There are a few cases in which this approach can cause issues:At the same time, rcheevos is able to auto-detect the console from the game when using the console ID
RC_CONSOLE_UNKNOWN.This PR improves the detection logic. It maintains the console mapping by emulator, preserving the existing behaviour. However, when the console cannot be detected from the mapping, the detection will not fail directly and will instead be handled by rcheevos by passing RC_CONSOLE_UNKNOWN.
Because of this, the
RA_initMemoryRegionscall was moved fromra_do_load_gametora_game_loaded_callback. There was a comment saying that the memory regions must be initialized before loading the game, but as far as I could test, this is not the case.