Skip to content

Remove unnecessary CHECK_INCLUDE_FILES() uses #8451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rubiefawn wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Remove unnecessary CHECK_INCLUDE_FILES() uses #8451

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,9 +181,7 @@ SET(CMAKE_CXX_STANDARD_REQUIRED ON)
CHECK_INCLUDE_FILES(pthread.h LMMS_HAVE_PTHREAD_H)
CHECK_INCLUDE_FILES(semaphore.h LMMS_HAVE_SEMAPHORE_H)
CHECK_INCLUDE_FILES(unistd.h LMMS_HAVE_UNISTD_H)
CHECK_INCLUDE_FILES(sys/types.h LMMS_HAVE_SYS_TYPES_H)
CHECK_INCLUDE_FILES(sys/ipc.h LMMS_HAVE_SYS_IPC_H)
CHECK_INCLUDE_FILES(sys/time.h LMMS_HAVE_SYS_TIME_H)
CHECK_INCLUDE_FILES(sys/times.h LMMS_HAVE_SYS_TIMES_H)
CHECK_INCLUDE_FILES(sys/prctl.h LMMS_HAVE_SYS_PRCTL_H)
CHECK_INCLUDE_FILES(sched.h LMMS_HAVE_SCHED_H)
Expand All @@ -192,7 +190,6 @@ CHECK_INCLUDE_FILES(soundcard.h LMMS_HAVE_SOUNDCARD_H)
CHECK_INCLUDE_FILES(fcntl.h LMMS_HAVE_FCNTL_H)
CHECK_INCLUDE_FILES(sys/ioctl.h LMMS_HAVE_SYS_IOCTL_H)
CHECK_INCLUDE_FILES(process.h LMMS_HAVE_PROCESS_H)
CHECK_INCLUDE_FILES(locale.h LMMS_HAVE_LOCALE_H)

include(CheckLibraryExists)
check_library_exists(rt shm_open "" LMMS_HAVE_LIBRT)
Expand Down
3 changes: 0 additions & 3 deletions doc/Doxyfile.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1970,10 +1970,8 @@ PREDEFINED = "LMMS_BUILD_LINUX=" \
"LMMS_DEBUG_FPE=" \
"LMMS_HAVE_PTHREAD_H=" \
"LMMS_HAVE_UNISTD_H=" \
"LMMS_HAVE_SYS_TYPES_H=" \
"LMMS_HAVE_SYS_IPC_H=" \
"LMMS_HAVE_SEMAPHORE_H=" \
"LMMS_HAVE_SYS_TIME_H=" \
"LMMS_HAVE_SYS_TIMES_H=" \
"LMMS_HAVE_SYS_PRCTL_H=" \
"LMMS_HAVE_SCHED_H=" \
Expand All @@ -1982,7 +1980,6 @@ PREDEFINED = "LMMS_BUILD_LINUX=" \
"LMMS_HAVE_FCNTL_H=" \
"LMMS_HAVE_SYS_IOCTL_H=" \
"LMMS_HAVE_PROCESS_H=" \
"LMMS_HAVE_LOCALE_H=" \

# If the MACRO_EXPANSION and EXPAND_ONLY_PREDEF tags are set to YES then this
# tag can be used to specify a list of macro names that should be expanded. The
Expand Down
5 changes: 1 addition & 4 deletions include/RemotePluginBase.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@

#include <atomic> // IWYU pragma: keep
#include <vector>
#include <clocale> // IWYU pragma: keep
#include <cstdio>
#include <cstdlib>
#include <cstring>
Expand All @@ -46,10 +47,6 @@
#endif
#endif // !(LMMS_HAVE_SYS_IPC_H && LMMS_HAVE_SEMAPHORE_H)

#ifdef LMMS_HAVE_LOCALE_H
#include <clocale> // IWYU pragma: keep
#endif

#ifdef LMMS_HAVE_PTHREAD_H
#include <pthread.h>
#endif
Expand Down
2 changes: 0 additions & 2 deletions src/common/RemotePluginBase.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,11 +44,9 @@ RemotePluginBase::RemotePluginBase() :
m_invalid(false)
#endif
{
#ifdef LMMS_HAVE_LOCALE_H
// make sure, we're using common ways to print/scan
// floats to/from strings (',' vs. '.' for decimal point etc.)
setlocale(LC_NUMERIC, "C");
#endif
#ifndef SYNC_WITH_SHM_FIFO
pthread_mutex_init(&m_receiveMutex, nullptr);
pthread_mutex_init(&m_sendMutex, nullptr);
Expand Down
3 changes: 0 additions & 3 deletions src/lmmsconfig.h.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,10 +41,8 @@

#cmakedefine LMMS_HAVE_PTHREAD_H
#cmakedefine LMMS_HAVE_UNISTD_H
#cmakedefine LMMS_HAVE_SYS_TYPES_H
#cmakedefine LMMS_HAVE_SYS_IPC_H
#cmakedefine LMMS_HAVE_SEMAPHORE_H
#cmakedefine LMMS_HAVE_SYS_TIME_H
#cmakedefine LMMS_HAVE_SYS_TIMES_H
#cmakedefine LMMS_HAVE_SYS_PRCTL_H
#cmakedefine LMMS_HAVE_SCHED_H
Expand All @@ -53,4 +51,3 @@
#cmakedefine LMMS_HAVE_FCNTL_H
#cmakedefine LMMS_HAVE_SYS_IOCTL_H
#cmakedefine LMMS_HAVE_PROCESS_H
#cmakedefine LMMS_HAVE_LOCALE_H
Loading