Skip to content

Remove background-color: var(--selectorBackgroundColor); from .itemEx…#34

Open
Macleykun wants to merge 1 commit into
KBH-Reeper:mainfrom
Macleykun:main
Open

Remove background-color: var(--selectorBackgroundColor); from .itemEx…#34
Macleykun wants to merge 1 commit into
KBH-Reeper:mainfrom
Macleykun:main

Conversation

@Macleykun

Copy link
Copy Markdown

…ternalLinks.focuscontainer-x > .button-link to make the icons fit the rest

Makes it from:
image

To:
image

…ternalLinks.focuscontainer-x > .button-link to make the icons fit the rest
@KBH-Reeper

Copy link
Copy Markdown
Owner

@Macleykun Can you please let me know what app you are using to convert the external link text to icons?

Also, initial look over - the removal of the background does impact the design choice to have the text to display as button rather then floating text. Once option, is to target the specific LetterBox, Radarr and Sonarr icons using this:

.itemExternalLinks.focuscontainer-x > a.arr-link,
.itemExternalLinks.focuscontainer-x > a.letterboxd-link {
    color: var(--textColor);
    background-color: inherit !important;
    padding: 0.125em 0.5em;
    border-radius: var(--smallerRadius);
    margin-bottom: 0.5em;
}

@Macleykun

Copy link
Copy Markdown
Author

@Macleykun Can you please let me know what app you are using to convert the external link text to icons?

Also, initial look over - the removal of the background does impact the design choice to have the text to display as button rather then floating text. Once option, is to target the specific LetterBox, Radarr and Sonarr icons using this:

.itemExternalLinks.focuscontainer-x > a.arr-link,
.itemExternalLinks.focuscontainer-x > a.letterboxd-link {
    color: var(--textColor);
    background-color: inherit !important;
    padding: 0.125em 0.5em;
    border-radius: var(--smallerRadius);
    margin-bottom: 0.5em;
}

The plugin JellyFin Enhanced does that!
image
But that relates to this part:
image

The Letterbox is from the same tweak and part of the config:
image

Which shows by default the icon but can be configured to show only the text
image

For Radarr/Sonarr icon it's the same story :)
image

@Macleykun

Copy link
Copy Markdown
Author

Almost forgot to test out the CSS you gave!
Gave that a try and also works perfectly! :)
I assume that on hover it still should show pink right?
image
(which is fine by me!)

@KBH-Reeper

Copy link
Copy Markdown
Owner

@Macleykun Good to hear it worked. And yes, it should still display a colour on hover as most of icons should be a "dedicate" colour to the service.

But regarding the icons for IMDb, tvDB and TMDB - I cant seem to find where these are

@Macleykun

Macleykun commented Jun 7, 2026

Copy link
Copy Markdown
Author

@Macleykun Good to hear it worked. And yes, it should still display a colour on hover as most of icons should be a "dedicate" colour to the service.

But regarding the icons for IMDb, tvDB and TMDB - I cant seem to find where these are

Had a bit of a look and i think i found where in your theme!
https://github.com/KBH-Reeper/GlassFin/blob/main/Theme/GlassFin-Theme-latest-stable.css#L1892C1-L1892C63
604107591-93791bcb-47d8-49a0-a06b-f7fe917cbcfe

Ah, so i wanted to say you shouldn't bother with it as it may have been something from the author of JellyFin Enhanced, but it's actually done by ElegantFin dev:

https://github.com/KBH-Reeper/GlassFin/blob/main/Theme/GlassFin-Theme-latest-stable.css#L1899

604107717-848e0b24-1c93-4f12-b25b-7dbb4f079e30

And here you can see how upstream does it: https://github.com/lscambo13/ElegantFin/blob/main/Theme/ElegantFin-theme-v26.06.06.css#L1934

For LetterBox the same filter trick can be used, but for the radarr/sonarr/(lidarr?) it might be possible to filter on [title*="radarr"]:hover,?

I'm going to have a go with it :)!

@Macleykun

Macleykun commented Jun 8, 2026

Copy link
Copy Markdown
Author

lscambo13/ElegantFin#297 is merged with the improvements of the hover. Do you wish for a seperate PR that does the same for glassfin or do you update from upstream in a different way?

then we can merge the removale of the bg for arr links and letterboxd, aswell as the hover's!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants