Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 26 additions & 8 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"devDependencies": {
"@commitlint/cli": "21.2.1",
"@commitlint/config-conventional": "21.2.0",
"conventional-changelog-conventionalcommits": "10.2.1",
"conventional-changelog-conventionalcommits": "9.3.1",
"husky": "^9.1.7",
"semantic-release": "25.0.7"
},
Expand Down
2 changes: 1 addition & 1 deletion templates/_helpers.tpl
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ If release name contains chart name it will be used as a full name.
Create chart name and version as used by the chart label.
*/}}
{{- define "git-hubby.chart" -}}
{{- printf "%s-%s" .Chart.Name .Chart.Version | replace "+" "_" | trunc 63 | trimSuffix "-" }}
{{- printf "%s-%s" .Chart.Name .Chart.Version | replace "+" "_" | trunc 63 | trimAll "-._" }}
{{- end }}

{{/*
Expand Down
38 changes: 38 additions & 0 deletions tests/labels_test.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,38 @@
suite: labels
templates:
- deployment.yaml
release:
name: test-release
namespace: test-ns
tests:
- it: should set helm.sh/chart label with name and version
asserts:
- equal:
path: metadata.labels["helm.sh/chart"]
value: "git-hubby-0.0.1"

- it: should set app.kubernetes.io/name selector label
asserts:
- equal:
path: metadata.labels["app.kubernetes.io/name"]
value: "git-hubby"

- it: should set app.kubernetes.io/instance selector label
asserts:
- equal:
path: metadata.labels["app.kubernetes.io/instance"]
value: "test-release"

- it: should set app.kubernetes.io/version label
asserts:
- equal:
path: metadata.labels["app.kubernetes.io/version"]
value: "0.4.5"

- it: should set app.kubernetes.io/managed-by label
asserts:
- equal:
path: metadata.labels["app.kubernetes.io/managed-by"]
value: "Helm"