Adds a complete (MMS) verification framework for 3D tetrahedral (P1) elements#31
Merged
Conversation
* [3D] Add quadrature rules for tetrahedra; invariant to node winding * [3D] Add tet elements strategy class * [3D] Wire in the tetra solution * [3D] Change to iterative preconditioned solver * [3D] Reduce amplitude of the sinusoidal wave * [3D] Switch to Dirichlet on 1 face and neumann on the other 5 * [3D] Remove bad comments * [3D] Increase amplitude * [3D] Bring back hex * [3D] Remove duplicated test code
th-skam
approved these changes
Jul 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a complete Method of Manufactured Solutions (MMS) verification framework for 3D tetrahedral (P1) elements, extending the existing 2D/3D MMS work to tetrahedral discretization.
The case involving Neumann boundary conditions does not currently reach the expected convergence rate. Convergence appears to stall, this needs further investigation before this case can be considered validated. All Dirichlet-based cases converge as expected.