Added ExtendedUnlockableItem ExtendedContent type#186
Merged
Conversation
- 'AssetBundles.AssetBundleLoader.OnBundleLoaded' was being invoked for all bundle files present, each time a new AssetBundleGroup was created. - I changed the visibility of 'AssetBundleInfo.assetBundle' from private to internal, but it could be exposed in some other way to keep it private.
- Everything should be set up to be registered just like other ExtendedContent, I don't think I missed anything... - Tested ship furniture and suits and they both seem to be working correctly. - Items showed up in the terminal store and could be purchased, terminal node text overrides applied correctly, and purchased items persisted upon reloading the lobby. - Also updated game assembies to v70.
- AssetBundleInfo's assetBundle field is back to being private. - I did test and the fix still works. - Switched adding unlockable items to the game's unlockables list from TerminalManager to ExtendedUnlockableItem.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
v70in the.csprojfileExtendedUnlockableItem, for ship unlockables (suits, ship furniture, ship upgrades)OnLethalBundleLoadedlisteners being called multiple times (once for every bundle found)Might not be quite enough to warrant a
v1.5.0LLL release, so I just left it atv1.4.12.