Fix DNF group advice#1111
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Linux dependency installation guidance in install.sh so DNF-based Fedora/RHEL-family systems are detected more reliably via /etc/os-release (ID and ID_LIKE), avoiding the legacy “Development Tools” group name when dnf expects development-tools.
Changes:
- Adjust DNF distro detection to match Fedora/RHEL-like systems using substring matches on
IDandID_LIKE. - Update the surrounding comment to reflect Fedora + RHEL-like behavior and keep the guidance aligned with DNF group IDs.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Fedora-derived and RHEL-derived systems may expose non-exact `ID` values in `/etc/os-release`. - Matching `ID` and `ID_LIKE` avoids recommending the legacy display group name where DNF expects `development-tools`.
MikeMcQuaid
force-pushed
the
fix/dnf-fedora-rhel-groups
branch
from
a5b5574 to
184a7bc
Compare
SMillerDev
approved these changes
Jun 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IDvalues in/etc/os-release.IDandID_LIKEavoids recommending the legacy display group name where DNF expectsdevelopment-tools.