fix(pi): hide detached process windows on Windows

internal/project/command_other.go

@@ -0,0 +1,12 @@
+//go:build !windows
+
+package project
+
+import (
+	"context"
+	"os/exec"
+)
+
+func newProjectCommandContext(ctx context.Context, name string, args ...string) *exec.Cmd {
+	return exec.CommandContext(ctx, name, args...)
+}

internal/project/command_other_test.go

@@ -0,0 +1,20 @@
+//go:build !windows
+
+package project
+
+import (
+	"context"
+	"reflect"
+	"testing"
+)
+
+func TestNewProjectCommandContextPreservesDefaultProcessAttributes(t *testing.T) {
+	cmd := newProjectCommandContext(context.Background(), "git", "status")
+
+	if want := []string{"git", "status"}; !reflect.DeepEqual(cmd.Args, want) {
+		t.Fatalf("command arguments = %q; want %q", cmd.Args, want)
+	}
+	if cmd.SysProcAttr != nil {
+		t.Fatalf("SysProcAttr = %#v; want nil", cmd.SysProcAttr)
+	}
+}

internal/project/command_usage_test.go

@@ -0,0 +1,61 @@
+package project
+
+import (
+	"go/ast"
+	"go/parser"
+	"go/token"
+	"path/filepath"
+	"runtime"
+	"testing"
+)
+
+func TestProjectDetectionGitCommandsUsePlatformHelper(t *testing.T) {
+	_, testFile, _, ok := runtime.Caller(0)
+	if !ok {
+		t.Fatal("locate test source")
+	}
+
+	file, err := parser.ParseFile(token.NewFileSet(), filepath.Join(filepath.Dir(testFile), "detect.go"), nil, 0)
+	if err != nil {
+		t.Fatalf("parse detect.go: %v", err)
+	}
+
+	tests := []struct {
+		name string
+	}{
+		{name: "detectGitRootDir"},
+		{name: "detectFromGitRemote"},
+	}
+
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			var function *ast.FuncDecl
+			for _, declaration := range file.Decls {
+				candidate, ok := declaration.(*ast.FuncDecl)
+				if ok && candidate.Name.Name == tt.name {
+					function = candidate
+					break
+				}
+			}
+			if function == nil {
+				t.Fatalf("function %s not found", tt.name)
+			}
+
+			helperCalls := 0
+			ast.Inspect(function.Body, func(node ast.Node) bool {
+				call, ok := node.(*ast.CallExpr)
+				if !ok {
+					return true
+				}
+				identifier, ok := call.Fun.(*ast.Ident)
+				if ok && identifier.Name == "newProjectCommandContext" {
+					helperCalls++
+				}
+				return true
+			})
+			if helperCalls != 1 {
+				t.Fatalf("%s uses newProjectCommandContext %d times; want 1", tt.name, helperCalls)
+			}
+		})
+	}
+}

internal/project/command_windows.go

@@ -0,0 +1,15 @@
+//go:build windows
+
+package project
+
+import (
+	"context"
+	"os/exec"
+	"syscall"
+)
+
+func newProjectCommandContext(ctx context.Context, name string, args ...string) *exec.Cmd {
+	cmd := exec.CommandContext(ctx, name, args...)
+	cmd.SysProcAttr = &syscall.SysProcAttr{HideWindow: true}
+	return cmd
+}

internal/project/command_windows_test.go

@@ -0,0 +1,23 @@
+//go:build windows
+
+package project
+
+import (
+	"context"
+	"reflect"
+	"testing"
+)
+
+func TestNewProjectCommandContextHidesWindow(t *testing.T) {
+	cmd := newProjectCommandContext(context.Background(), "git", "status")
+
+	if want := []string{"git", "status"}; !reflect.DeepEqual(cmd.Args, want) {
+		t.Fatalf("command arguments = %q; want %q", cmd.Args, want)
+	}
+	if cmd.SysProcAttr == nil {
+		t.Fatal("SysProcAttr is nil; want Windows process attributes")
+	}
+	if !cmd.SysProcAttr.HideWindow {
+		t.Fatal("SysProcAttr.HideWindow is false; want true")
+	}
+}

internal/project/detect.go

@@ -11,7 +11,6 @@ import (
 	"errors"
 	"fmt"
 	"os"
-	"os/exec"
 	"path/filepath"
 	"strings"
 	"time"
@@ -279,7 +278,7 @@ func detectGitRootDir(dir string) string {
 	ctx, cancel := context.WithTimeout(context.Background(), 2*time.Second)
 	defer cancel()
 
-	cmd := exec.CommandContext(ctx, "git", "-C", dir, "rev-parse", "--show-toplevel")
+	cmd := newProjectCommandContext(ctx, "git", "-C", dir, "rev-parse", "--show-toplevel")
 	out, err := cmd.Output()
 	if err != nil {
 		return ""
@@ -378,7 +377,7 @@ func detectFromGitRemote(dir string) string {
 	ctx, cancel := context.WithTimeout(context.Background(), 2*time.Second)
 	defer cancel()
 
-	cmd := exec.CommandContext(ctx, "git", "-C", dir, "remote", "get-url", "origin")
+	cmd := newProjectCommandContext(ctx, "git", "-C", dir, "remote", "get-url", "origin")
 	out, err := cmd.Output()
 	if err != nil {
 		return ""

plugin/pi/index.ts

@@ -383,6 +383,7 @@ function spawnDetached(command: string, args: readonly string[], cwd?: string):
     try {
       proc = spawn(command, [...args], {
         cwd,
+        windowsHide: true,
         detached: true,
         stdio: "ignore",
       });