Skip to content

feat: OpenFAST synchronization, docs updates, and VIV test fix#398

Open
RyanDavies19 wants to merge 7 commits into
FloatingArrayDesign:devfrom
RyanDavies19:improvements
Open

feat: OpenFAST synchronization, docs updates, and VIV test fix#398
RyanDavies19 wants to merge 7 commits into
FloatingArrayDesign:devfrom
RyanDavies19:improvements

Conversation

@RyanDavies19

@RyanDavies19 RyanDavies19 commented Jul 17, 2026

Copy link
Copy Markdown
Collaborator

OpenFAST Synchronization
Matching the code in OpenFAST, I added a new a line output channel (node accelerations, zero at end nodes) and a new rod out channel (node water velocities). I also added the waveKin_rampT ramp option (currents disabled during IC gen when ramping is active), which linearly ramps Water kinematics to prevent transients when starting up simulations. Finally, ! and % are now accepted as comment characters alongside #.

Documentation
Documented the above changes, clarified per-node tension vs. FairTen/AnchTen, noted WEC-Sim/MATLAB can frequently cause crashes because of the WECSim implementation, and added VIV theory/validation paper reference. The last one documents the theory behind PR #295.

Tests
The existing VIV test is failing due to the OpenFAST synchronization changes causing a numerical phase shift in the output tensions (from lock-in occurring at different time during start-up). This is being picked up because the test's peak finding approach is too basic, and gets triggered by noise rather than the true signal. Thus, I improved VIV peak detection (longer run, later first check, min-peak-amplitude threshold for stability) to better pick up peaks. In doing that I made a new plotting script for visual validation, and thought it would be good to include if any future work needs debugging. The two figures below compare the results to the OpenFAST regression tests, and show that the new test peaks are still within the acceptable range.
peaks
FFT

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@RyanDavies19

RyanDavies19 commented Jul 20, 2026

Copy link
Copy Markdown
Collaborator Author

@sanguinariojoe, requesting your review just so you are aware. There is nothing too major in here beyond an improved VIV test, and it is the code I used for the VIV paper (w/ validation study)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants