feat: OpenFAST synchronization, docs updates, and VIV test fix#398
Open
RyanDavies19 wants to merge 7 commits into
Open
feat: OpenFAST synchronization, docs updates, and VIV test fix#398RyanDavies19 wants to merge 7 commits into
RyanDavies19 wants to merge 7 commits into
Conversation
…ater-kinematic ramping enabled
Collaborator
Author
|
@sanguinariojoe, requesting your review just so you are aware. There is nothing too major in here beyond an improved VIV test, and it is the code I used for the VIV paper (w/ validation study) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OpenFAST Synchronization
Matching the code in OpenFAST, I added a new a line output channel (node accelerations, zero at end nodes) and a new rod out channel (node water velocities). I also added the waveKin_rampT ramp option (currents disabled during IC gen when ramping is active), which linearly ramps Water kinematics to prevent transients when starting up simulations. Finally,
!and%are now accepted as comment characters alongside#.Documentation
Documented the above changes, clarified per-node tension vs. FairTen/AnchTen, noted WEC-Sim/MATLAB can frequently cause crashes because of the WECSim implementation, and added VIV theory/validation paper reference. The last one documents the theory behind PR #295.
Tests


The existing VIV test is failing due to the OpenFAST synchronization changes causing a numerical phase shift in the output tensions (from lock-in occurring at different time during start-up). This is being picked up because the test's peak finding approach is too basic, and gets triggered by noise rather than the true signal. Thus, I improved VIV peak detection (longer run, later first check, min-peak-amplitude threshold for stability) to better pick up peaks. In doing that I made a new plotting script for visual validation, and thought it would be good to include if any future work needs debugging. The two figures below compare the results to the OpenFAST regression tests, and show that the new test peaks are still within the acceptable range.