fix(Utils): add guard against null rule value in validateRule#7779
Open
afsuyadi wants to merge 1 commit into
Open
fix(Utils): add guard against null rule value in validateRule#7779afsuyadi wants to merge 1 commit into
afsuyadi wants to merge 1 commit into
Conversation
|
@afsuyadi is attempting to deploy a commit to the Flagsmith Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a PR! Please check the boxes below:
docs/if required so people know about the feature.Changes
Contributes to #7536
CreateSegmentcomponent is trying to call methodvalidateRule()by passing an object.split()method is executed on a variable that isn't string-type.validateRule(), only value prop that is accessed and doesn't have its own guard, so the method crashes when it's empty (either null or undefined).How did you test this code?
Screencast.from.14-06-26.11.46.58.webm