Fix server crash when read a malformed replication segment#9055
Merged
dyemanov merged 3 commits intoJun 19, 2026
Conversation
aafemt
reviewed
Jun 8, 2026
… was. Also add a length check to the defineAtom function.
dyemanov
requested changes
Jun 18, 2026
dyemanov
approved these changes
Jun 19, 2026
dyemanov
pushed a commit
that referenced
this pull request
Jun 19, 2026
* Fix server crash when read a malformed replication segment * Revert the length definition in the getString function back to how it was. Also add a length check to the defineAtom function. * Сorrection after Dmitry Yemanov review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a segment has some damage and it falls on the length of a string or the position of an atom, then the server crash with SIGSEGV, instead of output an correct error