Skip to content

fix: use github owner login for webhook deploy matching#4674

Open
agentHits wants to merge 1 commit into
Dokploy:canaryfrom
agentHits:fix/github-webhook-owner-login
Open

fix: use github owner login for webhook deploy matching#4674
agentHits wants to merge 1 commit into
Dokploy:canaryfrom
agentHits:fix/github-webhook-owner-login

Conversation

@agentHits

@agentHits agentHits commented Jun 21, 2026

Copy link
Copy Markdown

What is this PR about?

This PR fixes GitHub auto-deploy matching for GitHub App webhooks. Dokploy
stores the selected GitHub repository owner from repo.owner.login, but the
push/tag webhook handler matched configured applications and compose projects
against repository.owner.name. GitHub push payloads can omit owner.name, so
valid pushes could be received and verified but still find zero deployable
resources, leaving auto-deploy inactive after new GitHub commits.

The handler now resolves the repository owner as
repository.owner.login ?? repository.owner.name and uses the same value for
tag, push, and preview-deployment matching. The regression test covers push
application, push compose, tag deploy, and a branch mismatch negative case
using a payload with owner.login and no owner.name.

Checklist

Before submitting this PR, please make sure that:

  • You created a dedicated branch based on the canary branch.
  • You have read the suggestions in the CONTRIBUTING.md file https://github.com/Dokploy/dokploy/blob/canary/CONTRIBUTING.md#pull-request
  • You have tested this PR in your local instance. If you have not tested it yet, please do so before submitting. This helps avoid wasting maintainers' time reviewing code that has not been verified by you.

Testing

  • pnpm --dir apps/dokploy exec vitest --config __test__/vitest.config.ts run __test__/deploy/github-webhook-handler.test.ts __test__/deploy/github.test.ts __test__/deploy/should-deploy.test.ts
  • pnpm --dir apps/dokploy run typecheck
  • pnpm exec biome check apps/dokploy/pages/api/deploy/github.ts apps/dokploy/__test__/deploy/github-webhook-handler.test.ts
  • git diff --check upstream/canary...HEAD

Issues related (if applicable)

Fixes #4675

Screenshots (if applicable)

N/A - webhook/API behavior only.

@agentHits agentHits marked this pull request as ready for review June 21, 2026 17:48
@agentHits agentHits requested a review from Siumauricio as a code owner June 21, 2026 17:48
@dosubot dosubot Bot added size:XS This PR changes 0-9 lines, ignoring generated files. bug Something isn't working labels Jun 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

GitHub auto-deploy does not trigger when webhook owner name is missing

1 participant