fix: use github owner login for webhook deploy matching#4674
Open
agentHits wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR about?
This PR fixes GitHub auto-deploy matching for GitHub App webhooks. Dokploy
stores the selected GitHub repository owner from
repo.owner.login, but thepush/tag webhook handler matched configured applications and compose projects
against
repository.owner.name. GitHub push payloads can omitowner.name, sovalid pushes could be received and verified but still find zero deployable
resources, leaving auto-deploy inactive after new GitHub commits.
The handler now resolves the repository owner as
repository.owner.login ?? repository.owner.nameand uses the same value fortag, push, and preview-deployment matching. The regression test covers push
application, push compose, tag deploy, and a branch mismatch negative case
using a payload with
owner.loginand noowner.name.Checklist
Before submitting this PR, please make sure that:
canarybranch.Testing
pnpm --dir apps/dokploy exec vitest --config __test__/vitest.config.ts run __test__/deploy/github-webhook-handler.test.ts __test__/deploy/github.test.ts __test__/deploy/should-deploy.test.tspnpm --dir apps/dokploy run typecheckpnpm exec biome check apps/dokploy/pages/api/deploy/github.ts apps/dokploy/__test__/deploy/github-webhook-handler.test.tsgit diff --check upstream/canary...HEADIssues related (if applicable)
Fixes #4675
Screenshots (if applicable)
N/A - webhook/API behavior only.