feat(self-updating-mastra): add committed "aws" Defang stack file#649
Closed
defang-sam[bot] wants to merge 1 commit into
Closed
feat(self-updating-mastra): add committed "aws" Defang stack file#649defang-sam[bot] wants to merge 1 commit into
defang-sam[bot] wants to merge 1 commit into
Conversation
Creates the AWS deployment stack (`.defang/aws`, us-east-1) for the self-updating-mastra sample alongside the existing GCP `beta` stack. The file is force-added: `.defang/` is normally gitignored (both repo-root and sample-level), but this sample self-redeploys from its own build context, so committing the stack config makes the AWS target explicit and available. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds a new Defang deployment stack
awsfor theself-updating-mastrasample, created viadefang stack new aws --provider aws --region us-east-1.The stack file is committed at
samples/self-updating-mastra/.defang/aws:This complements the existing GCP
betastack, giving the sample an AWS target.Why committed (deviation from convention)
.defang/is normally gitignored — both at the repo root and in this sample's own.gitignore— and the samples guide says not to commit it. This file is intentionally force-added becauseself-updating-mastrais a self-redeploying sample whose own build context is what gets shipped; committing the stack config makes the AWS deployment target explicit and inspectable. Only this one file is tracked; the rest of.defang/stays ignored.Base branch
Targets
feature/self-updating-mastra(notmain) so it stacks on the in-progress feature (PR #648) rather than dragging the whole feature into a diff againstmain.Deploy
The
awsstack is being deployed to AWS (us-east-1) viadefang compose up --stack awsas part of this task; deploy status will be reported separately.🤖 Generated with Claude Code
Samples Checklist
✅ All good!