[dspace-9_x] Fix #4734: resolve bitstream download link with UI namespace#5848
Open
hernanhlagos wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
References
Description
This PR fixes the bitstream download button in the item edit bitstreams page when DSpace Angular 9 is deployed under a UI namespace / context path, for example
/repository.The fix updates the download button to use
[routerLink]instead of[href], matching the behavior already present indspace-10_x.Instructions for Reviewers
List of changes in this PR:
item-edit-bitstream-bundle.component.htmlfrom[href]="entry.downloadUrl"to[routerLink]="entry.downloadUrl".This issue occurs when DSpace Angular is deployed under a UI namespace, for example:
How to reproduce the issue
ui.nameSpace: /repository.Before this change
The rendered link omits the configured UI namespace:
This causes the browser to resolve the URL from the root of the host instead of under
/repository.After this change
The rendered link includes the configured UI namespace:
This matches the behavior already present in
dspace-10_x.Checklist
mainbranch of code (unless it is a backport or is fixing an issue specific to an older branch).npm run lintnpm run check-circ-deps)package.json), I've made sure their licenses align with the [DSpace BSD License](https://github.com/DSpace/DSpace/blob/main/LICENSE) based on the [Licensing of Contributions](https://wiki.lyrasis.org/display/DSPACE/Code+Contribution+Guidelines#CodeContributionGuidelines-LicensingofContributions) documentation.