disable_arc_fitting on K1 machines#579
Open
RodentVienna wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The K1 Series, whether it's K1, K1C, K1 Max, or whatever K1 models are out there, have a very weak MCU that often triggers MQO or TTC errors related to long or complex move queues, which literally shut down the MCU or even crash it with no proper HW debug options, due to the K1 potato board not having a JTAG port. Gigatons of Filament were wasted worldwide.
All the K1* process profiles have "enable_arc_fitting" enabled by default. This setting very often is disabled by users., as there is no real benefit in Klipper versus Marlin.
By disabling them by default, we get more reliable prints, especially if the gcode is very complex, thus saving MCU resources.