Skip to content

Fix LDAP TLS client certificate options must be set before ldap_connect() for Google Secure LDAP #945

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mikelog wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Fix LDAP TLS client certificate options must be set before ldap_connect() for Google Secure LDAP #945

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions datamodels/2.x/authent-ldap/datamodel.authent-ldap.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,16 @@
$this->LogInfo($bDebug, "ldap_set_option('LDAP_OPT_DEBUG_LEVEL', '{$aOptions[LDAP_OPT_DEBUG_LEVEL]}') returned ".($bRet ? 'true' : 'false'));
}

// Set TLS options globally BEFORE ldap_connect() - required for ldaps:// with client certificates
// (e.g. Google Workspace Secure LDAP). OpenLDAP requires TLS context options (LDAP_OPT_X_TLS_CACERTFILE,
// LDAP_OPT_X_TLS_CERTFILE, LDAP_OPT_X_TLS_KEYFILE) to be set on the global context (null) before
// ldap_connect() is called, otherwise the TLS handshake fails on the first attempt per PHP-FPM worker.
foreach ($aOptions as $name => $value)
{
ldap_set_option(null, $name, $value);
$this->LogInfo($bDebug, "ldap_set_option(null, '$name', '$value')");
}

$hDS = @ldap_connect($sURI);
if ($hDS === false)
{
Expand Down