N°8952 - Correct variable naming and syntax errors in webhook actions

[ritoban23]

Base information

Question	Answer
Related to a SourceForge thead / Another PR / Combodo ticket?
Type of change?	Bug fix

Symptom (bug) / Objective (enhancement)

• In src/Core/Notification/Action/_ActionWebhook.php, the code referenced $this->m_aWebrequestErrors instead of the correct $this->aRequestErrors, causing runtime errors.
• The same file had a syntax error: case WebRequestSender::ENUM_SEND_STATE_ERROR; (semicolon instead of colon).
• In tests/php-unit-tests/_ActionWebhookTest.php, unused imports (Exception, ReflectionException) were present.

Reproduction procedure (bug)

2. With module version x.y.z

3. With PHP x.y.z

4. Trigger a webhook action that results in an error (e.g., invalid callback signature).

5. Observe PHP notices about undefined property or syntax errors in logs.
   -->

6. On iTop 3.x.x

7. With module version 1.x.x

8. With PHP 7.4+ or 8.x

9. Trigger a webhook action that should log errors (e.g., misconfigured callback).

10. See PHP notice: "Undefined property: ...m_aWebrequestErrors"

11. See parse error if the switch case is hit.

Cause (bug)

• Typo in property name: should be $this->aRequestErrors
• Syntax error in switch statement: should use colon, not semicolon

Proposed solution (bug and enhancement)

• Corrected property name in _ActionWebhook.php
• Fixed switch case syntax
• Removed unused imports in _ActionWebhookTest.php

Checklist before requesting a review

• I have performed a self-review of my code
• I have tested all changes I made on an iTop instance
• Would a unit test be relevant and have I added it? (N/A, covered by existing tests)
• Is the PR clear and detailed enough so anyone can understand without digging in the code?

Checklist of things to do before PR is ready to merge

• Review requested changes (if any)
• Confirm all tests pass
• Update documentation if needed

[jf-cbd]

Hello, thank you for your PR and for correcting errors :)
I just have a question : ReflectionException seems to be used in the PHPDoc of testCheckCallbackSignature, why do you suggest removing it ?

[ritoban23]

@jf-cbd You're right, thank you for catching that! and Exception is documented too, my bad....ill update the changes, thanks

[jf-cbd]

Hey @ritoban23, we should approve and merge your PR in the month.
Your PR is a nice catch, and we'd like to send you stickers (about iTop and Hacktoberfest), as a thank you for your contribution. If you want to receive some, please send us your address at community[at]combodo.com

[Copilot]

Pull request overview

This PR fixes two runtime-breaking issues in the webhook action execution path by correcting an invalid property reference used for error reporting and by fixing a PHP switch syntax error. These changes improve reliability of webhook notifications and prevent notices/parse errors during execution.

Changes:

• Replace references to non-existent $this->m_aWebrequestErrors with the existing $this->aRequestErrors.
• Fix switch syntax by changing case ...; to case ...: for the error sender state branch.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.