fix: align vendored TypeSpec stack with Network specs#558
Merged
Conversation
necusjz
changed the title
huiii99
force-pushed
the
feat/support-typespec-v1
branch
6 times, most recently
from
20bc308 to
4a05221
Compare
…/ azure-core 0.69) ci: bump Node to 22.x for TypeSpec 1.13 submodule (requires node >=22) ci: bump pnpm to 10.30.2 to match TypeSpec submodule (fixes frozen-lockfile overrides mismatch) ci: build TypeSpec packages in the submodule workspace build:typespec previously ran `pnpm -r build` from the repo root, which pulls the vendored src/typespec packages into the root workspace and resolves a different @alloy-js/cli + typescript than the submodule pins. That mismatch makes `alloy build` (emitter-framework, tspd, http-client*) crash with `ts.sys` undefined. Building with `pnpm -C src/typespec -r` uses the submodule's own resolution, where alloy builds correctly; the turbo monorepo root and the doc websites are excluded, and typespec-aaz is built separately afterwards. Verified: full build + pnpm bundle succeed with compiler 1.13 / azure-core 0.69 libs present.
huiii99
force-pushed
the
feat/support-typespec-v1
branch
from
4a05221 to
156e896
Compare
- convertor: don't fabricate nextLinkName="nextLink" for continuationToken paging; leave it empty so downstream emits no pager instead of a broken one - package.json: add engines (node>=22, pnpm>=10) matching the vendored TypeSpec 1.13 submodule requirement - docs: bump local dev prerequisites to Node 22+ / pnpm 10+ - pnpm-workspace: document minimumReleaseAge CI time-window behavior and add TODO to drop the @alloy-js/cli typescript packageExtensions hack upstream
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Browser-side TypeSpec compilation of current Microsoft.Network RPs failed in the workspace editor (invalid-ref / invalid-argument / versioning errors) because the src/typespec submodule was pinned to an old release (compiler 1.4, azure-core 0.60) while the specs are authored against compiler 1.13 / azure-core 0.69.
compiler 1.4->1.13, azure-core 0.60->0.69, ARM/tcgc->0.69
mirrored from the submodule so pnpm 9 can resolve catalog: specifiers
(pnpm 9.5.0 ignores overrides in pnpm-workspace.yaml)
(getPagedResult/PagedResultMetadata -> getPagingOperation); stricter enum guard
(ARM 0.69 is unversioned)
on /Swagger/Specs/Stat from over-long resolver paths
continues instead of aborting the compile
diagnostics instead of the misleading "tsp-output undefined not found"