fix: tagging secrets not being scoped by sender#24772
Open
nventuro wants to merge 1 commit into
Open
Conversation
nchamo
approved these changes
Jul 17, 2026
Comment on lines
+130
to
+131
| additionalScopes: AztecAddress[] = [], | ||
| sendMessagesAs?: AztecAddress, |
Contributor
There was a problem hiding this comment.
I really think we shouldn't use default values and optional params. I think we should force each caller to make a decision, or we could end up with another bug like the current one
Suggested change
| additionalScopes: AztecAddress[] = [], | |
| sendMessagesAs?: AztecAddress, | |
| additionalScopes: AztecAddress[], | |
| sendMessagesAs: AztecAddress | undefined, |
| }); | ||
|
|
||
| describe('getAppTaggingSecret', () => { | ||
| it('rejects a sender outside the execution scopes', async () => { |
Contributor
There was a problem hiding this comment.
We should probably add a test that actually doesn't throw when the sender is scoped correctly?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a scoping bug where an account's ivsk would be used to produce an ECDH shared secret even if that account was not in scope. The base wallet class was adjusted to put these in scope when an explicit sender is selected for tagged messages.