fix(ci): repair nightly barretenberg debug build failures#24766
Draft
AztecBot wants to merge 1 commit into
Draft
fix(ci): repair nightly barretenberg debug build failures#24766AztecBot wants to merge 1 commit into
AztecBot wants to merge 1 commit into
Conversation
AztecBot
added
ci-draft
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The nightly barretenberg debug build exposed two debug-only/CI bootstrap failures:
redis_setexzpiped throughgzipeven when Redis was unavailable. In the staleaztec-claudescheduled run this madegziphit SIGPIPE before EC2 bootstrap could start.AcirComponentsCheckTest.DetectsUnconstrainedWitnessessimulated a missing witness by shrinkingbuilder.real_variable_index, leaving synthesized gates with out-of-range witness references. Debug STL caught this as an out-of-bounds vector access and aborted the public nightly debug run.This PR makes Redis writes no-op safely when Redis is unavailable, keeps persistent log upload flowing to S3, and changes the ACIR components test corruption to remove the witness from synthesized wires without invalidating the builder's index vectors.
Verification
bash -n ci3/source_redis ci3/source_cachegit diff --checkbash -c 'set -euo pipefail; export CI=1 CI_REDIS=127.0.0.1 CI_REDIS_AVAILABLE=0 DASHBOARD_URL=http://ci.aztec-labs.com; source ci3/source_redis; echo "CI booting..." | redis_setexz test-key 300; echo redis_setexz_ok'bash -c 'set -euo pipefail; export CI=1 CI_REDIS=127.0.0.1 CI_REDIS_AVAILABLE=0 DASHBOARD_URL=http://ci.aztec-labs.com CI_REDIS_EXPIRE=1; source ci3/source_redis; source ci3/source_cache; printf final-log | cache_persistent test-key 1; echo cache_persistent_ok'cmake --build --preset debug --target acir_components_check_tests && ./build-debug/bin/acir_components_check_tests --gtest_filter=AcirComponentsCheckTest.DetectsUnconstrainedWitnesses./build-debug/bin/acir_components_check_testsCreated by claudebox · group:
slackbot