refactor(txe): replace AztecNodeService with TXE-local node#24758
Open
nchamo wants to merge 2 commits into
Open
refactor(txe): replace AztecNodeService with TXE-local node#24758nchamo wants to merge 2 commits into
nchamo wants to merge 2 commits into
Conversation
nventuro
reviewed
Jul 17, 2026
| /** | ||
| * {@link AztecNode} implementation in which every method throws. TXENode extends it, overriding the read-side | ||
| * queries the TXE actually serves, so any surface the TXE doesn't cover fails loudly instead of silently | ||
| * misbehaving. Method order mirrors the interface declaration. |
Contributor
There was a problem hiding this comment.
Suggested change
| * misbehaving. Method order mirrors the interface declaration. | |
| * misbehaving. |
| super(); | ||
| } | ||
|
|
||
| public override async findLeavesIndexes( |
Contributor
There was a problem hiding this comment.
These are non-trivial untested impls. I'm not saying the previous approach was better, but it doesn't seem fantastic to copy-paste these here either.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
TXE only used
AztecNodeServiceas a read-only facade over its own archiver and world state, yet the dependency pulled the whole server stack (p2p, sequencer, validator, prover, slasher, epoch-cache, ethereum) into its graph, plus ~400 lines of fakes whose only purpose was satisfying the node constructor. Decoupling TXE from the node also removes a blocker for splitting the repo, where TXE lands on the client-tooling side.The change
TXENodeserves the read-side queries the PXE services actually call (blocks, membership witnesses, logs by tags, tx receipts, contract data, public storage) directly overTXEArchiverandTXESynchronizer. It extendsUnimplementedAztecNode, a full transcription of theAztecNodeinterface whose methods throw, so any surface the TXE does not cover fails loudly.DummyP2P,MockEpochCacheand the TXE global-variable/fee builders; dropped the@aztec/aztec-nodeand@aztec/bb-proverdependencies along with the esbuild stubs that existed only to neutralize the node import graph in the TXE bundle.getContractaccepts block-hash reference parameters.proven/finalized) matchesgetL2Tipsinstead of resolving to genesis.