refactor(pxe): nameless wire-structural labels and ResolvedTx cleanup#24755
Open
nchamo wants to merge 1 commit into
Open
refactor(pxe): nameless wire-structural labels and ResolvedTx cleanup#24755nchamo wants to merge 1 commit into
nchamo wants to merge 1 commit into
Conversation
nchamo
marked this pull request as ready for review
July 16, 2026 19:06
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #24752, folding in cleanup that belongs with it:
{field,u32}), so a label encodes exactly what the wire does: anything the wire tolerates (a field rename, a struct-in-struct nesting refactor) no longer moves the interface hash, and a genuine layout change still does.camelToSnakeis gone with it.ResolvedTxbecomes a plain type. refactor(pxe): compute oracle interface hash from mapping labels #24752 moved its wire layout into theRESOLVED_TXstruct mapping, which orphaned the class'stoFields(). The class, its inline-data pin test, and the Noirresolved_tx_serialization_matches_typescriptcounterpart are deleted — the generated oracle tests already verify that wire end-to-end.RETRACTABLE_FACT_ORIGIN.blockStatemaps as a validatedorigin-block-statescalar instead of theU32placeholder, following the same honest-types direction as theBYTE→U8rename in refactor(pxe): compute oracle interface hash from mapping labels #24752.Both interface hashes (PXE and TXE) are re-pinned; the wire is unchanged, so the oracle versions are untouched.