Skip to content

Test/coverage#97

Merged
noamteyssier merged 12 commits into
dev-0.9.4from
test/coverage
Jul 7, 2026
Merged

Test/coverage#97
noamteyssier merged 12 commits into
dev-0.9.4from
test/coverage

Conversation

@noamteyssier

Copy link
Copy Markdown
Collaborator

No description provided.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request significantly improves test coverage across the codebase by adding comprehensive unit tests for headers, readers, writers, records, and block indices in the bq, cbq, record, and vbq modules. It also updates StreamReader to track record IDs independently of the buffer position using a new records_read field. The review feedback identifies three key issues in the test code: a Windows-specific test failure caused by deleting a file while it is still memory-mapped, a fragile reliance on std::mem::size_of for determining serialized header sizes, and the potential for leftover temporary files on disk if tests panic. Implementing RAII guards for file cleanup and using robust serialization offsets will resolve these issues.

Comment thread src/bq/reader.rs
Comment thread src/cbq/core/block.rs Outdated
Comment thread src/vbq/index.rs
@noamteyssier noamteyssier merged commit ec3b43a into dev-0.9.4 Jul 7, 2026
14 checks passed
@noamteyssier noamteyssier deleted the test/coverage branch July 7, 2026 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant