ci: 🛠️ add Crowdin translation upload and download workflows#225
Conversation
- Introduced `.github/workflows/crowdin-upload.yml` for uploading English source files and translations to Crowdin. - Added `.github/workflows/crowdin-download.yml` to download translations, create automated PRs, and handle versioning of translation files.
|
is there any technical reason why the upload workflow only uploads english translations? Whenever i add new things, i usually add English, German and French from the start. wouldnt this fail to sync the german and french translations then? |
| uses: crowdin/github-action@v2 | ||
| with: | ||
| upload_sources: true | ||
| upload_translations: true |
There was a problem hiding this comment.
@Cinnazeyy as you can see it uploads both, source + translations to presave our current workflow
Our workflow now have to be merge new translations -> merge the pr with new source strings. Else we override the translations on crowdin. Not sure if we have to document that somewhere, is only relevant for Repo maintainers.
| with: | ||
| upload_sources: false | ||
| upload_translations: false | ||
| download_sources: false |
There was a problem hiding this comment.
@Agrrox had the idea to also sync the source back to the repo. Normally that's a thing you don't do. I think people cannot even suggest strings there, not sure if we Crowdin "Manager's" can change it inside there.
My preferred workflow regarding errors in source strings would be a comment/issue on crowdin or a issue here on GitHub, and we fix that then manually. Shouldn't happen that often too. (There are currently some smaller issues)
@Cinnazeyy what do you think? Should we override the source with crowdin?
.github/workflows/crowdin-upload.ymlfor uploading English source files and translations to Crowdin..github/workflows/crowdin-download.ymlto download translations, create automated PRs, and handle versioning of translation files.All the config-version logic can be removed as soon as we use a proper system which doesn't rely on config-version for upgrading.
Before merging old translations needs to be downloaded and the current setup removed on crowdin. As soon as this is merged it will also be added to our other repos where we have translations.
This has be tested extensively on a private repo so should work fine.