From 7614e627d12e63dae3e008aed52aaed38ea7fa0b Mon Sep 17 00:00:00 2001 From: "Joshua M. Boniface" Date: Thu, 19 Feb 2026 14:32:20 -0500 Subject: [PATCH 1/2] Add --search-domains flag to dns options command Expose the supervisor's search_domains DNS option via the CLI, mirroring the existing --servers flag. Accepts multiple values via repeated use of the flag. ha dns options --search-domains example.com --search-domains corp.example.com --- cmd/dns_options.go | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/cmd/dns_options.go b/cmd/dns_options.go index 4e598d3e..ab6e234c 100644 --- a/cmd/dns_options.go +++ b/cmd/dns_options.go @@ -17,6 +17,7 @@ running Home Assistant DNS server. `, Example: ` ha dns options --servers dns://8.8.8.8 --servers dns://1.1.1.1 + ha dns options --search-domains example.com --search-domains corp.example.com `, ValidArgsFunction: cobra.NoFileCompletions, Args: cobra.NoArgs, @@ -35,6 +36,13 @@ running Home Assistant DNS server. options["servers"] = servers } + searchDomains, err := cmd.Flags().GetStringArray("search-domains") + log.WithField("search-domains", searchDomains).Debug("search-domains") + + if cmd.Flags().Changed("search-domains") && err == nil { + options["search_domains"] = searchDomains + } + data, err := cmd.Flags().GetBool("fallback") if err == nil && cmd.Flags().Changed("fallback") { options["fallback"] = data @@ -52,11 +60,13 @@ running Home Assistant DNS server. func init() { dnsOptionsCmd.Flags().StringArrayP("servers", "r", []string{}, "Upstream DNS servers to use. Use multiple times for multiple servers.") + dnsOptionsCmd.Flags().StringArray("search-domains", []string{}, "DNS search domains written to container resolv.conf. Use multiple times for multiple domains.") dnsOptionsCmd.Flags().BoolP("fallback", "", true, "Enable/Disable fallback DNS (Cloudflare DoT)") dnsOptionsCmd.Flags().Lookup("fallback").NoOptDefVal = "true" dnsOptionsCmd.RegisterFlagCompletionFunc("servers", cobra.NoFileCompletions) + dnsOptionsCmd.RegisterFlagCompletionFunc("search-domains", cobra.NoFileCompletions) dnsOptionsCmd.RegisterFlagCompletionFunc("fallback", boolCompletions) dnsCmd.AddCommand(dnsOptionsCmd) From 765abfe99eac6460658299660df028aab668edc6 Mon Sep 17 00:00:00 2001 From: "Joshua M. Boniface" Date: Fri, 29 May 2026 01:33:31 -0400 Subject: [PATCH 2/2] Apply review suggestion for slog.Debug Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> --- cmd/dns_options.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cmd/dns_options.go b/cmd/dns_options.go index ab6e234c..f06e93bd 100644 --- a/cmd/dns_options.go +++ b/cmd/dns_options.go @@ -37,7 +37,7 @@ running Home Assistant DNS server. } searchDomains, err := cmd.Flags().GetStringArray("search-domains") - log.WithField("search-domains", searchDomains).Debug("search-domains") + slog.Debug("search-domains", "search-domains", searchDomains) if cmd.Flags().Changed("search-domains") && err == nil { options["search_domains"] = searchDomains