From b3b5cb714d45c0266a94c77489c27882e5b2b4b2 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?L=C3=A9on=20=22Avic=22=20Simmons?= Date: Sat, 6 Jun 2026 02:19:16 -0400 Subject: [PATCH] docs: fix typos in comments and error messages MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit - functor.md + functor.py: enviroment → environment - slices.cc + test: concatentation → concatenation - data_bag.cc: withing → within - schema_helper.py: overriden → overridden - group_by_utils.h: indicies → indices --- docs/api/kd/functor.md | 2 +- koladata/internal/data_bag.cc | 2 +- koladata/internal/op_utils/group_by_utils.h | 4 ++-- koladata/operators/slices.cc | 2 +- py/koladata/ext/storage/schema_helper.py | 2 +- py/koladata/operators/functor.py | 2 +- py/koladata/operators/tests/slices_concat_test.py | 2 +- 7 files changed, 8 insertions(+), 8 deletions(-) diff --git a/docs/api/kd/functor.md b/docs/api/kd/functor.md index 22cebe38..ef6da9e5 100644 --- a/docs/api/kd/functor.md +++ b/docs/api/kd/functor.md @@ -182,7 +182,7 @@ Returns:
Special call that will be transformed to expect fn to return a stream.
 
 It should be used only if functor is provided externally in production
-enviroment. Prefer `functor.call` for functors fully implemented in Python.
+environment. Prefer `functor.call` for functors fully implemented in Python.
 
 Args:
   fn: function to be called. Should return Iterable in interactive mode and
diff --git a/koladata/internal/data_bag.cc b/koladata/internal/data_bag.cc
index 35b85bae..363b91b5 100644
--- a/koladata/internal/data_bag.cc
+++ b/koladata/internal/data_bag.cc
@@ -360,7 +360,7 @@ absl::Status MergeToMutableDenseSource(
       auto other_items,
       GetAttributeFromSources(objects, {&dense_source}, sparse_sources));
   // GetAttributeFromSources returns information about unset values in
-  // TypesBuffer withing DataSliceImpl. Ensure that TypesBuffer is there.
+  // TypesBuffer within DataSliceImpl. Ensure that TypesBuffer is there.
   DCHECK_GT(size, 0);
   DCHECK(!other_items.types_buffer().id_to_typeidx.empty());
 
diff --git a/koladata/internal/op_utils/group_by_utils.h b/koladata/internal/op_utils/group_by_utils.h
index c1f42a04..65d2f63f 100644
--- a/koladata/internal/op_utils/group_by_utils.h
+++ b/koladata/internal/op_utils/group_by_utils.h
@@ -81,7 +81,7 @@ class ObjectsGroupBy {
       const arolla::DenseArray& objs) {
     ASSIGN_OR_RETURN(auto group_sizes,
                      arolla::DenseArrayEdgeSizesOp()(&ctx_, edge));
-    ASSIGN_OR_RETURN(auto indicies, agg_index_op_.Apply(edge, objs.ToMask()));
+    ASSIGN_OR_RETURN(auto indices, agg_index_op_.Apply(edge, objs.ToMask()));
     std::vector> objs_grouped_bldr;
     objs_grouped_bldr.reserve(group_sizes.size());
     group_sizes.ForEachPresent([&](int64_t idx, int64_t size) {
@@ -91,7 +91,7 @@ class ObjectsGroupBy {
         [&](size_t idx, ObjectId new_obj, int64_t group_id, int64_t index) {
           objs_grouped_bldr[group_id].Set(index - 1, new_obj);
         },
-        objs, edge.ToMappingEdge().edge_values(), indicies));
+        objs, edge.ToMappingEdge().edge_values(), indices));
     std::vector> objs_grouped;
     objs_grouped.reserve(group_sizes.size());
     for (auto& bldr : objs_grouped_bldr) {
diff --git a/koladata/operators/slices.cc b/koladata/operators/slices.cc
index 7fb887db..c49d6894 100644
--- a/koladata/operators/slices.cc
+++ b/koladata/operators/slices.cc
@@ -168,7 +168,7 @@ absl::StatusOr ConcatOrStackImpl(bool stack, int64_t ndim,
   if (!stack) {  // concat
     if (rank == 0) {
       return absl::InvalidArgumentError(
-          "concatentation of DataItems (rank=0) is not supported - use stack "
+          "concatenation of DataItems (rank=0) is not supported - use stack "
           "instead");
     } else if (ndim < 1 || ndim > rank) {
       return absl::InvalidArgumentError(
diff --git a/py/koladata/ext/storage/schema_helper.py b/py/koladata/ext/storage/schema_helper.py
index 2cd92bfa..e49c39ff 100644
--- a/py/koladata/ext/storage/schema_helper.py
+++ b/py/koladata/ext/storage/schema_helper.py
@@ -712,7 +712,7 @@ def get_affected_schema_node_names(
     Which schema node names of updated_ds.get_schema() could be affected by this
     update? A schema node name is affected if the update can provide it with new
     data. So schema node names that are newly introduced are affected, as are
-    existing schema node names for which the update can provide new/overriden
+    existing schema node names for which the update can provide new/overridden
     data.
 
     Important to note:
diff --git a/py/koladata/operators/functor.py b/py/koladata/operators/functor.py
index a686902d..3d2e34b5 100644
--- a/py/koladata/operators/functor.py
+++ b/py/koladata/operators/functor.py
@@ -160,7 +160,7 @@ def call_fn_returning_stream_when_parallel(
   """Special call that will be transformed to expect fn to return a stream.
 
   It should be used only if functor is provided externally in production
-  enviroment. Prefer `functor.call` for functors fully implemented in Python.
+  environment. Prefer `functor.call` for functors fully implemented in Python.
 
   Args:
     fn: function to be called. Should return Iterable in interactive mode and
diff --git a/py/koladata/operators/tests/slices_concat_test.py b/py/koladata/operators/tests/slices_concat_test.py
index 4591aeea..51066886 100644
--- a/py/koladata/operators/tests/slices_concat_test.py
+++ b/py/koladata/operators/tests/slices_concat_test.py
@@ -160,7 +160,7 @@ def test_default_output(self):
           ),
           0,
           (
-              'concatentation of DataItems (rank=0) is not supported - use'
+              'concatenation of DataItems (rank=0) is not supported - use'
               ' stack instead'
           ),
       ),