Skip to content

Fix broken prerequisite in account deactivation docs#25297

Merged
craig-osterhout merged 1 commit into
docker:mainfrom
jasdeepbhalla:fix/account-deactivation-unlink-prereq
Jun 10, 2026
Merged

Fix broken prerequisite in account deactivation docs#25297
craig-osterhout merged 1 commit into
docker:mainfrom
jasdeepbhalla:fix/account-deactivation-unlink-prereq

Conversation

@jasdeepbhalla

Copy link
Copy Markdown
Contributor

Description

The prerequisites section for deactivating a Docker account contained a broken bullet:

Unlink your GitHub and account

"GitHub and account" is not grammatical. The linked page covers unlinking both GitHub and Bitbucket accounts (for the deprecated automated builds feature), but only GitHub was mentioned.

This fix:

  • Rewrites the bullet to be grammatically correct
  • Clarifies it only applies to users who linked accounts for automated builds
  • Adds a link for Bitbucket alongside GitHub

Related issues or tickets

Fixes #25128

Reviews

  • Technical review
  • Editorial review

The previous prerequisite 'Unlink your GitHub and account' was grammatically
broken and only mentioned GitHub, leaving out Bitbucket. Updated to clarify
that this step applies only if the user linked accounts for the deprecated
automated builds feature, and added a link for Bitbucket as well.

Fixes docker#25128
@netlify

netlify Bot commented Jun 6, 2026

Copy link
Copy Markdown

Deploy Preview for docsdocker ready!

Name Link
🔨 Latest commit 50cc6b8
🔍 Latest deploy log https://app.netlify.com/projects/docsdocker/deploys/6a249c44fcb63e000871f77b
😎 Deploy Preview https://deploy-preview-25297--docsdocker.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions github-actions Bot added the area/accounts Relates to Docker accounts label Jun 6, 2026
@craig-osterhout

Copy link
Copy Markdown
Contributor

/review

@craig-osterhout craig-osterhout added the status/review Pull requests that are ready for review label Jun 10, 2026

@docker-agent docker-agent left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assessment: 🟢 APPROVE

The fix correctly addresses the broken prerequisite bullet in the account deactivation docs:

  • Replaces the ungrammatical "Unlink your GitHub and account" with a well-formed conditional sentence
  • Appropriately scopes the requirement to users who linked accounts for automated builds
  • Adds the missing Bitbucket link alongside the GitHub one

No style guide violations, no AI-isms, no scope inflation, and no redirect concerns (no pages removed or moved). The change is minimal and matches the document's existing tone and brevity.

@craig-osterhout craig-osterhout left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you. lgtm

@craig-osterhout craig-osterhout merged commit 0391eab into docker:main Jun 10, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/accounts Relates to Docker accounts status/review Pull requests that are ready for review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[docs-scanner] Incomplete and grammatically broken prerequisite for account deactivation

3 participants