fix(providers/anthropic): send thinking display by ibetitsmike · Pull Request #39 · coder/fantasy

ibetitsmike · 2026-06-04T10:45:36Z

Summary

Adds a typed Anthropic ThinkingDisplay provider option with summarized and omitted values.
Sends thinking.display for adaptive thinking and budget-token thinking, defaulting omitted-display models to summarized when thinking is enabled.
Converts budget-token thinking on adaptive-only models to adaptive thinking, while preserving plain Opus 4.7+ calls without a thinking field.
Inlines the build workflow so govulncheck runs with Go 1.26.4 while the module baseline stays Go 1.25.0.

Tests

GOTOOLCHAIN=go1.26.4 go test ./... -count=1 -timeout=30m
GOTOOLCHAIN=go1.26.4 govulncheck ./...
GOTOOLCHAIN=go1.26.4 /home/coder/.mux-tmp/bin/golangci-lint run ./...
actionlint .github/workflows/build.yml

Mux working on behalf of Mike.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b4aff3f2f9

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

ibetitsmike · 2026-06-04T11:00:44Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 3b73808645

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

ibetitsmike · 2026-06-04T11:04:33Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 83457e118a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

ibetitsmike · 2026-06-04T11:08:52Z

@codex review

ibetitsmike · 2026-06-04T12:40:41Z

/coder-agents-review

ibetitsmike · 2026-06-04T13:41:38Z

/coder-agents-review

ibetitsmike · 2026-06-04T13:45:36Z

/coder-agents-review

ibetitsmike · 2026-06-04T14:30:14Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e4da4814f1

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

ibetitsmike · 2026-06-04T14:34:33Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 63052c1708

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

ibetitsmike · 2026-06-04T14:48:26Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 587a0432a1

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

ibetitsmike · 2026-06-04T15:02:08Z

@codex review

chatgpt-codex-connector · 2026-06-04T15:05:07Z

Codex Review: Didn't find any major issues. 👍

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

## Summary - Updates Coder's pinned `github.com/coder/fantasy` fork to include coder/fantasy#39. - Exposes Anthropic `thinking_display` as a typed chat model provider option with `summarized` and `omitted` values. - Validates configured `thinking_display` values and maps them to `fantasyanthropic.ProviderOptions.ThinkingDisplay`. - Regenerates the API/UI option schemas so the admin model config form gets a generated select field. ## Tests - `go mod tidy` - `make gen` - `go test ./codersdk ./coderd/x/chatd/chatprovider ./coderd -run 'TestChatModelProviderOptions|TestAnthropicThinkingDisplayFromChat|TestProviderOptionsFromChatModelConfig_AnthropicThinkingDisplay|TestMergeMissingProviderOptions_AnthropicThinkingDisplay|TestValidateChatModelProviderOptions_AnthropicThinkingDisplay'` - `go test ./coderd/x/chatd/... ./codersdk` - `go test ./coderd -run 'TestValidateChatModelProviderOptions_AnthropicThinkingDisplay'` - `pnpm --dir site exec -- biome lint --error-on-warnings src/api/chatModelOptionsGenerated.json src/api/typesGenerated.ts` - pre-commit hook, including fmt, lint, and slim build > Mux working on behalf of Mike.

fix(providers/anthropic): send thinking display

b4aff3f

github-actions Bot added the provider: anthropic claude label Jun 4, 2026

chatgpt-codex-connector Bot reviewed Jun 4, 2026

View reviewed changes

Comment thread providers/anthropic/anthropic.go

fix(providers/anthropic): require opus minor segment

3b73808

chatgpt-codex-connector Bot reviewed Jun 4, 2026

View reviewed changes

Comment thread providers/anthropic/anthropic.go

fix(providers/anthropic): default mythos thinking display

83457e1

chatgpt-codex-connector Bot reviewed Jun 4, 2026

View reviewed changes

Comment thread providers/anthropic/anthropic.go

fix(providers/anthropic): enable mythos adaptive display

2542a29

fix: repair coder branch checks

e2d606b

fix(ci): use safe Go toolchain

77adb6a

fix(ci): pin govulncheck toolchain

3ec9260

fix(ci): rely on go.mod toolchain

e4da481

chatgpt-codex-connector Bot reviewed Jun 4, 2026

View reviewed changes

Comment thread .github/workflows/build.yml Outdated

fix(ci): clear reusable go version default

63052c1

chatgpt-codex-connector Bot reviewed Jun 4, 2026

View reviewed changes

Comment thread go.mod Outdated

Comment thread providers/anthropic/anthropic.go Outdated

ibetitsmike added 3 commits June 4, 2026 14:39

fix(providers/anthropic): use adaptive thinking defaults

b2129c1

fix(providers/anthropic): treat omitted opus models as adaptive

53c3982

fix(ci): run checks with safe go toolchain

587a043

chatgpt-codex-connector Bot reviewed Jun 4, 2026

View reviewed changes

Comment thread providers/anthropic/anthropic.go

ibetitsmike added 2 commits June 4, 2026 15:01

fix(providers/anthropic): keep opus thinking opt-in

e448439

fix(ci): run govulncheck on fixed toolchain

70ffdab

ibetitsmike merged commit a2a3f21 into coder_2_33 Jun 4, 2026
16 checks passed

ibetitsmike mentioned this pull request Jun 4, 2026

fix: show Anthropic Opus 4.7+ thinking coder/coder#26026

Merged

Conversation

ibetitsmike commented Jun 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Tests

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

ibetitsmike commented Jun 4, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

ibetitsmike commented Jun 4, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

ibetitsmike commented Jun 4, 2026

Uh oh!

ibetitsmike commented Jun 4, 2026

Uh oh!

ibetitsmike commented Jun 4, 2026

Uh oh!

ibetitsmike commented Jun 4, 2026

Uh oh!

ibetitsmike commented Jun 4, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

ibetitsmike commented Jun 4, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

ibetitsmike commented Jun 4, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

ibetitsmike commented Jun 4, 2026

Uh oh!

chatgpt-codex-connector Bot commented Jun 4, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

ibetitsmike commented Jun 4, 2026 •

edited

Loading