Refactor configuration SystemVMDefaultHypervisor by GaOrtiga · Pull Request #8934 · apache/cloudstack

GaOrtiga · 2024-04-17T18:29:00Z

Description

The configuration SystemVMDefaultHypervisor is not dynamic, it is necessary to restart the management server after each alteration to its value. Besides, its input is a String, which forces the user to type in the name of the chosen hypervisor, being subject to typos.

This configuration was refactored, allowing its value to be altered in runtime; besides, its input was converted to a select, in order to facilitate the process of choosing the new value.

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)
build/CI

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Bug Severity

How Has This Been Tested?

I changed the values of the configurations and verified that the default hypervisors for new system vms changed accordingly

sureshanaparti · 2024-04-18T08:23:58Z

@blueorangutan package

blueorangutan · 2024-04-18T08:26:06Z

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2024-04-18T09:45:09Z

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9306

DaanHoogland · 2024-04-19T12:44:30Z

@blueorangutan test

blueorangutan · 2024-04-19T12:46:04Z

@DaanHoogland a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan · 2024-04-20T08:01:23Z

[SF] Trillian test result (tid-9929)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 47242 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8934-t9929-kvm-centos7.zip
Smoke tests completed. 127 look OK, 2 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_01_events_resource	`Error`	300.66	test_events_resource.py
test_01_events_resource	`Error`	300.67	test_events_resource.py
test_04_deploy_vm_for_other_user_and_test_vm_operations	`Failure`	92.05	test_network_permissions.py
ContextSuite context=TestNetworkPermissions>:teardown	`Error`	1.45	test_network_permissions.py

BryanMLima · 2024-06-12T18:20:40Z

@blueorangutan package

blueorangutan · 2024-06-12T18:22:03Z

@BryanMLima a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

codecov · 2024-06-12T18:28:29Z

Codecov Report

❌ Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 17.59%. Comparing base (f958896) to head (29843c8).
⚠️ Report is 536 commits behind head on 4.22.

Files with missing lines	Patch %	Lines
...n/java/com/cloud/resource/ResourceManagerImpl.java	0.00%	2 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               4.22    #8934      +/-   ##
============================================
+ Coverage     16.57%   17.59%   +1.01%     
- Complexity    13986    15599    +1613     
============================================
  Files          5746     5910     +164     
  Lines        510859   529730   +18871     
  Branches      62140    64718    +2578     
============================================
+ Hits          84696    93216    +8520     
- Misses       416689   426021    +9332     
- Partials       9474    10493    +1019

Flag	Coverage Δ
uitests	`3.57% <ø> (-0.34%)`	⬇️
unittests	`18.66% <50.00%> (+1.19%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

blueorangutan · 2024-06-12T19:41:24Z

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9908

JoaoJandre · 2024-08-13T19:34:23Z

@blueorangutan package

blueorangutan · 2024-08-13T19:36:03Z

@JoaoJandre a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2024-08-13T20:45:20Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✖️ debian ✔️ suse15. SL-JID 10640

GaOrtiga · 2024-09-12T17:34:20Z

@blueorangutan package

blueorangutan · 2024-09-12T17:36:03Z

@GaOrtiga a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2024-09-12T18:46:21Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11102

DaanHoogland · 2024-09-16T14:01:09Z

@GaOrtiga @BryanMLima what is the status of this PR?
@sureshanaparti @weizhouapache , any concerns to be dealt with?

GaOrtiga · 2024-09-18T18:43:11Z

@GaOrtiga @BryanMLima what is the status of this PR? @sureshanaparti @weizhouapache , any concerns to be dealt with?

It is ready for review.

DaanHoogland · 2024-09-19T18:45:58Z

@blueorangutan package

blueorangutan · 2024-09-19T18:48:03Z

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2024-09-19T19:23:38Z

Packaging result [SF]: ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 11154

blueorangutan · 2024-09-20T08:41:58Z

Packaging result [SF]: ✔️ el8 ✖️ el9 ✔️ debian ✖️ suse15. SL-JID 11158

github-actions · 2025-03-27T17:36:01Z

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

DaanHoogland · 2025-10-10T08:52:19Z

@blueorangutan package

blueorangutan · 2025-10-10T08:54:07Z

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

DaanHoogland · 2025-10-10T09:11:24Z

@GaOrtiga ,can you address this comment:
#8934 (comment) , please?

blueorangutan · 2025-10-10T11:49:17Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 15395

DaanHoogland · 2025-12-02T07:47:56Z

@sureshanaparti @weizhouapache are you ok with this as is?

DaanHoogland · 2025-12-02T08:45:19Z

@blueorangutan test

blueorangutan · 2025-12-02T08:46:04Z

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

blueorangutan · 2025-12-02T23:12:13Z

[SF] Trillian test result (tid-14896)
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 49033 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8934-t14896-kvm-ol8.zip
Smoke tests completed. 149 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File

DaanHoogland · 2025-12-23T17:18:28Z

@sureshanaparti @weizhouapache are your concerns met?

weizhouapache

code lgtm

sureshanaparti · 2026-01-09T09:22:57Z

@sureshanaparti @weizhouapache are your concerns met?

looks good, need some testing with multiple hypervisors env.

GaOrtiga · 2026-01-12T16:19:43Z

@sureshanaparti @weizhouapache are your concerns met?

looks good, need some testing with multiple hypervisors env.

@sureshanaparti I did not test in an env with multiple hypervisors, but I did test changing the value and seeing if the defined hypervisor would be passed during system VM creation (which worked).

harikrishna-patnala

Tested in my existing environment.

"system.vm.default.hypervisor" value changed from null to "Any"
Did not find any issues in getting up a new system VM
Changed the setting to "KVM" and new system VM came up well

* refactor configuration SystemVMDefaultHypervisor * change variable name --------- Co-authored-by: Gabriel <gabriel.fernandes@scclouds.com.br>

GaOrtiga changed the title ~~refactor configuration SystemVMDefaultHypervisor~~ Refactor configuration SystemVMDefaultHypervisor Apr 17, 2024

sureshanaparti reviewed Apr 18, 2024

View reviewed changes

Comment thread engine/components-api/src/main/java/com/cloud/resource/ResourceManager.java

BryanMLima closed this Jun 12, 2024

BryanMLima reopened this Jun 12, 2024

GaOrtiga force-pushed the Refactor_config_SystemVMDefaultHypervisor branch from 9d226fe to 13becce Compare September 12, 2024 17:01

github-actions Bot added the status:has-conflicts label Mar 27, 2025

sureshanaparti added this to the 4.21.0 milestone Jun 5, 2025

sureshanaparti moved this to In Progress in Apache CloudStack 4.22.0 Aug 29, 2025

harikrishna-patnala modified the milestones: 4.22.0, 4.22.1 Nov 12, 2025

harikrishna-patnala removed this from Apache CloudStack 4.22.0 Nov 12, 2025

DaanHoogland added the status:needs-testing label Dec 2, 2025

DaanHoogland changed the base branch from main to 4.22 December 2, 2025 07:48

rajujith added this to Apache CloudStack 4.22.1 Jan 5, 2026

rajujith moved this to In Progress in Apache CloudStack 4.22.1 Jan 7, 2026

weizhouapache approved these changes Jan 9, 2026

View reviewed changes

sureshanaparti reviewed Jan 9, 2026

View reviewed changes

Comment thread server/src/main/java/com/cloud/resource/ResourceManagerImpl.java Outdated

change variable name

29843c8

harikrishna-patnala self-assigned this Jan 27, 2026

harikrishna-patnala approved these changes Jan 27, 2026

View reviewed changes

harikrishna-patnala added status:ready-for-merge and removed status:needs-testing labels Jan 27, 2026

harikrishna-patnala merged commit 128dbe2 into apache:4.22 Jan 27, 2026
26 checks passed

harikrishna-patnala removed the status:ready-for-merge label Jan 27, 2026

Conversation

GaOrtiga commented Apr 17, 2024

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

How Has This Been Tested?

Uh oh!

Uh oh!

sureshanaparti commented Apr 18, 2024

Uh oh!

blueorangutan commented Apr 18, 2024

Uh oh!

blueorangutan commented Apr 18, 2024

Uh oh!

DaanHoogland commented Apr 19, 2024

Uh oh!

blueorangutan commented Apr 19, 2024

Uh oh!

blueorangutan commented Apr 20, 2024

Uh oh!

BryanMLima commented Jun 12, 2024

Uh oh!

blueorangutan commented Jun 12, 2024

Uh oh!

codecov Bot commented Jun 12, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

blueorangutan commented Jun 12, 2024

Uh oh!

JoaoJandre commented Aug 13, 2024

Uh oh!

blueorangutan commented Aug 13, 2024

Uh oh!

blueorangutan commented Aug 13, 2024

Uh oh!

GaOrtiga commented Sep 12, 2024

Uh oh!

blueorangutan commented Sep 12, 2024

Uh oh!

blueorangutan commented Sep 12, 2024

Uh oh!

DaanHoogland commented Sep 16, 2024

Uh oh!

GaOrtiga commented Sep 18, 2024

Uh oh!

DaanHoogland commented Sep 19, 2024

Uh oh!

blueorangutan commented Sep 19, 2024

Uh oh!

blueorangutan commented Sep 19, 2024

Uh oh!

blueorangutan commented Sep 20, 2024

Uh oh!

github-actions Bot commented Mar 27, 2025

Uh oh!

DaanHoogland commented Oct 10, 2025

Uh oh!

blueorangutan commented Oct 10, 2025

Uh oh!

DaanHoogland commented Oct 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

blueorangutan commented Oct 10, 2025

Uh oh!

DaanHoogland commented Dec 2, 2025

Uh oh!

DaanHoogland commented Dec 2, 2025

Uh oh!

blueorangutan commented Dec 2, 2025

Uh oh!

blueorangutan commented Dec 2, 2025

Uh oh!

DaanHoogland commented Dec 23, 2025

Uh oh!

weizhouapache left a comment

Choose a reason for hiding this comment

Uh oh!

codecov Bot commented Jun 12, 2024 •

edited

Loading

DaanHoogland commented Oct 10, 2025 •

edited

Loading