fix: clean magic value, and update if-else to switch by cheng102e · Pull Request #8848 · apache/cloudstack

cheng102e · 2024-03-29T09:12:05Z

Description

This PR...

clean magic value, and update if-else to switch

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)
build/CI

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Bug Severity

BLOCKER
Critical
Major
Minor
Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

boring-cyborg · 2024-03-29T09:12:09Z

Congratulations on your first Pull Request and welcome to the Apache CloudStack community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md)
Here are some useful points:

In case of a new feature add useful documentation (raise doc PR at https://github.com/apache/cloudstack-documentation)
Be patient and persistent. It might take some time to get a review or get the final approval from the committers.
Pay attention to the quality of your code, ensure tests are passing and your PR doesn't have conflicts.
Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Issues, Mailing list and Slack.
Be sure to read the CloudStack Coding Conventions.
Apache CloudStack is a community-driven project and together we are making it better 🚀.
In case of doubts contact the developers at:
Mailing List: dev@cloudstack.apache.org (https://cloudstack.apache.org/mailing-lists.html)
Slack: https://apachecloudstack.slack.com/

DaanHoogland · 2024-03-29T16:40:38Z

@blueorangutan package

blueorangutan · 2024-03-29T16:42:03Z

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

codecov · 2024-03-29T16:48:35Z

Codecov Report

❌ Patch coverage is 0% with 19 lines in your changes missing coverage. Please review.
✅ Project coverage is 17.60%. Comparing base (128dbe2) to head (d29fda7).
⚠️ Report is 20 commits behind head on 4.22.

Files with missing lines	Patch %	Lines
...-proxy/rdpconsole/src/main/java/common/Client.java	0.00%	19 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff            @@
##               4.22    #8848   +/-   ##
=========================================
  Coverage     17.60%   17.60%           
- Complexity    15615    15616    +1     
=========================================
  Files          5911     5911           
  Lines        529966   529967    +1     
  Branches      64747    64748    +1     
=========================================
+ Hits          93285    93289    +4     
+ Misses       426180   426178    -2     
+ Partials      10501    10500    -1

Flag	Coverage Δ
uitests	`3.60% <ø> (ø)`
unittests	`18.67% <0.00%> (+<0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

blueorangutan · 2024-03-29T17:52:33Z

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9099

DaanHoogland

clgtm

DaanHoogland · 2024-04-02T09:40:22Z

@blueorangutan test alma9 kvm-alma9

blueorangutan · 2024-04-02T09:42:03Z

@DaanHoogland a [SL] Trillian-Jenkins test job (alma9 mgmt + kvm-alma9) has been kicked to run smoke tests

weizhouapache · 2024-04-02T10:16:01Z

suggestion:

use EnumUtils.getEnumIgnoreCase with a default value

blueorangutan · 2024-04-03T01:12:20Z

[SF] Trillian test result (tid-9656)
Environment: kvm-alma9 (x2), Advanced Networking with Mgmt server a9
Total time taken: 53600 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8848-t9656-kvm-alma9.zip
Smoke tests completed. 127 look OK, 2 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_02_enableHumanReadableLogs	`Error`	0.16	test_human_readable_logs.py
test_03_secured_to_nonsecured_vm_migration	`Error`	155.35	test_vm_life_cycle.py
test_04_nonsecured_to_secured_vm_migration	`Error`	274.39	test_vm_life_cycle.py

DaanHoogland · 2024-04-03T08:09:06Z

suggestion:

use EnumUtils.getEnumIgnoreCase with a default value

@cheng102e , will you replace the switch statement?

sureshanaparti · 2024-04-08T12:02:02Z


+    private static final String VNC = "vnc";
+    private static final String RDP = "rdp";
+    private static final String HYPERV = "hyperv";


i think, no need of this string definitions, try with string to enum constant conversion?

sureshanaparti · 2025-06-05T10:04:17Z

@blueorangutan package

Copilot

Pull Request Overview

This PR refactors the protocol selection logic for the RDP console client by replacing magic-string comparisons with static constant values and updating an if-else chain to a switch statement.

Removed magic values by introducing constants for protocol names.
Replaced an if-else chain with a switch statement to improve clarity and maintainability.

DaanHoogland · 2025-10-10T08:25:48Z

@cheng102e , will you still be looking at this (and answer #8848 (comment)) ?

sureshanaparti

minor nit, current code lgtm

sureshanaparti · 2025-10-10T08:34:49Z

@blueorangutan package

blueorangutan · 2025-10-14T06:09:55Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 15448

RosiKyu · 2025-10-14T08:40:17Z

@blueorangutan test

blueorangutan · 2025-10-14T08:42:04Z

@rosi-shapeblue a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

blueorangutan · 2025-10-15T01:41:54Z

[SF] Trillian test result (tid-14661)
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 57653 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8848-t14661-kvm-ol8.zip
Smoke tests completed. 149 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File

rajujith · 2026-01-13T05:48:39Z

@cheng102e Since this is for the 4.22.1 release, could you retarget the PR to the 4.22 branch?

sureshanaparti · 2026-01-27T07:11:32Z

@blueorangutan package

blueorangutan · 2026-01-27T07:12:04Z

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2026-01-27T08:10:13Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 16552

sureshanaparti · 2026-01-27T11:00:30Z

@blueorangutan package

blueorangutan · 2026-01-27T11:02:05Z

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2026-01-27T11:53:13Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✖️ debian ✔️ suse15. SL-JID 16561

sureshanaparti · 2026-01-27T11:55:20Z

@blueorangutan test

blueorangutan · 2026-01-27T11:56:03Z

@sureshanaparti a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

blueorangutan · 2026-01-28T02:26:34Z

[SF] Trillian test result (tid-15306)
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 49413 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8848-t15306-kvm-ol8.zip
Smoke tests completed. 149 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File

boring-cyborg · 2026-01-28T04:45:14Z

Awesome work, congrats on your first merged pull request!

* fix: clean magic value, and update if-else to switch * fix: return the (String args[]) * review --------- Co-authored-by: jiejc1 <jiejc1@lenovo.com> Co-authored-by: Suresh Kumar Anaparti <sureshkumar.anaparti@gmail.com>

fix: clean magic value, and update if-else to switch

a8000d5

boring-cyborg Bot added the component:console-proxy label Mar 29, 2024

fix: return the (String args[])

78fac07

DaanHoogland added the type:cleanup label Apr 2, 2024

DaanHoogland approved these changes Apr 2, 2024

View reviewed changes

sureshanaparti reviewed Apr 8, 2024

View reviewed changes

sureshanaparti requested a review from Copilot June 5, 2025 10:03

Copilot AI reviewed Jun 5, 2025

View reviewed changes

Comment thread services/console-proxy/rdpconsole/src/main/java/common/Client.java

sureshanaparti added this to the 4.21.0 milestone Jun 5, 2025

sureshanaparti added this to Apache CloudStack 4.21.0 Jun 5, 2025

sureshanaparti moved this to In Progress in Apache CloudStack 4.21.0 Jul 14, 2025

weizhouapache modified the milestones: 4.21.0, 4.22.0 Aug 29, 2025

sureshanaparti removed this from Apache CloudStack 4.21.0 Aug 29, 2025

sureshanaparti added this to Apache CloudStack 4.22.0 Aug 29, 2025

sureshanaparti moved this to In Progress in Apache CloudStack 4.22.0 Aug 29, 2025

sureshanaparti approved these changes Oct 10, 2025

View reviewed changes

harikrishna-patnala modified the milestones: 4.22.0, 4.22.1 Nov 12, 2025

harikrishna-patnala removed this from Apache CloudStack 4.22.0 Nov 12, 2025

rajujith added this to Apache CloudStack 4.22.1 Jan 5, 2026

rajujith moved this to In Progress in Apache CloudStack 4.22.1 Jan 7, 2026

DaanHoogland changed the base branch from main to 4.22 January 13, 2026 12:40

sureshanaparti closed this Jan 27, 2026

sureshanaparti reopened this Jan 27, 2026

Merge branch '4.22' into fix/service_client

82362a0

DaanHoogland reviewed Jan 27, 2026

View reviewed changes

Comment thread services/console-proxy/rdpconsole/src/main/java/common/Client.java

Comment thread services/console-proxy/rdpconsole/src/main/java/common/Client.java Outdated

review

d29fda7

sureshanaparti merged commit 062b98a into apache:4.22 Jan 28, 2026
25 of 26 checks passed

DaanHoogland removed the status:needs-testing label Jan 28, 2026

Conversation

cheng102e commented Mar 29, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Uh oh!

boring-cyborg Bot commented Mar 29, 2024

Uh oh!

DaanHoogland commented Mar 29, 2024

Uh oh!

blueorangutan commented Mar 29, 2024

Uh oh!

codecov Bot commented Mar 29, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

blueorangutan commented Mar 29, 2024

Uh oh!

DaanHoogland left a comment

Choose a reason for hiding this comment

Uh oh!

DaanHoogland commented Apr 2, 2024

Uh oh!

blueorangutan commented Apr 2, 2024

Uh oh!

weizhouapache commented Apr 2, 2024

Uh oh!

blueorangutan commented Apr 3, 2024

Uh oh!

DaanHoogland commented Apr 3, 2024

Uh oh!

sureshanaparti Apr 8, 2024

Choose a reason for hiding this comment

Uh oh!

sureshanaparti commented Jun 5, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

DaanHoogland commented Oct 10, 2025

Uh oh!

sureshanaparti left a comment

Choose a reason for hiding this comment

Uh oh!

sureshanaparti commented Oct 10, 2025

Uh oh!

blueorangutan commented Oct 14, 2025

Uh oh!

RosiKyu commented Oct 14, 2025

Uh oh!

blueorangutan commented Oct 14, 2025

Uh oh!

blueorangutan commented Oct 15, 2025

Uh oh!

rajujith commented Jan 13, 2026

Uh oh!

sureshanaparti commented Jan 27, 2026

Uh oh!

blueorangutan commented Jan 27, 2026

Uh oh!

blueorangutan commented Jan 27, 2026

Uh oh!

Uh oh!

Uh oh!

sureshanaparti commented Jan 27, 2026

Uh oh!

blueorangutan commented Jan 27, 2026

Uh oh!

blueorangutan commented Jan 27, 2026

Uh oh!

sureshanaparti commented Jan 27, 2026

Uh oh!

cheng102e commented Mar 29, 2024 •

edited

Loading

codecov Bot commented Mar 29, 2024 •

edited

Loading